Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we actually include the workload manifest targets in the package #1827

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

danegsta
Copy link
Member

@danegsta danegsta commented Jan 24, 2024

Targets weren't getting packaged in the workload manifest nuget

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 24, 2024
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add some sort of validation that runs after packaging to ensure the files are there and fail the build if they aren't?

@danegsta
Copy link
Member Author

LGTM, should we add some sort of validation that runs after packaging to ensure the files are there and fail the build if they aren't?

Probably a good idea; I'd vote for doing that in a separate PR though, just so we can get this unblocked for testing ASAP.

@drewnoakes
Copy link
Member

LGTM, should we add some sort of validation that runs after packaging to ensure the files are there and fail the build if they aren't?

In the .NET Project System we have a similar test that uses the Verify library to track the contents of our VSIX file, which works really well. The set of expected files is kept in a text file in the repo.

https://github.com/dotnet/project-system/tree/main/tests/Microsoft.VisualStudio.ProjectSystem.Managed.VS.UnitTests/Setup

@danegsta danegsta merged commit 49ff271 into dotnet:main Jan 24, 2024
8 checks passed
@danmoseley danmoseley added area-acquisition and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants