Update orchestration discovery properties #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-integrations
joperezr
reviewed
Jan 24, 2024
| @@ -114,11 +114,13 @@ internal static class ]]>%(ClassName)<
There was a problem hiding this comment.
Can something potentially break from making this whole target conditional where it wasn't before? (Before we were defaulting DcpDir if not set)
Not super familiar with these targets, so asking just in case.
There was a problem hiding this comment.
It'll change the error the user sees; currently we report that we can't find the orchestrator at the fallback DcpDir path we were setting, but that path was a holdover from the pre-workload days. After the change, we'll throw a different error in DcpOptions.ApplyApplicationConfiguration when we see the CliPath wasn't set by the expected attribute.
joperezr
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize the MSBuild properties for orchestration discovery to use Dir suffix for directories and Path suffix for file names (to match the new dashboard discovery properties). Removes default path behavior for attributes if DcpDir isn't defined (workload is missing).
Microsoft Reviewers: Open in CodeFlow