Remove IServiceEndPointResolver.DisplayName property and use ToString() instead

src/Microsoft.Extensions.ServiceDiscovery.Abstractions/IServiceEndPointResolver.cs

@@ -8,11 +8,6 @@ namespace Microsoft.Extensions.ServiceDiscovery.Abstractions;
 /// </summary>
 public interface IServiceEndPointResolver : IAsyncDisposable
 {
-    /// <summary>
-    /// Gets the diagnostic display name for this resolver.
-    /// </summary>
-    string DisplayName { get; }
-
     /// <summary>
     /// Attempts to resolve the endpoints for the service which this instance is configured to resolve endpoints for.
     /// </summary>

src/Microsoft.Extensions.ServiceDiscovery.Dns/DnsServiceEndPointResolver.cs

@@ -23,7 +23,7 @@ internal sealed partial class DnsServiceEndPointResolver(
     string IHostNameFeature.HostName => hostName;
 
     /// <inheritdoc/>
-    public override string DisplayName => "DNS";
+    public override string ToString() => "DNS";
 
     protected override async Task ResolveAsyncCore()
     {

src/Microsoft.Extensions.ServiceDiscovery.Dns/DnsServiceEndPointResolverBase.cs

@@ -44,16 +44,18 @@ protected DnsServiceEndPointResolverBase(
         _lastChangeToken = new CancellationChangeToken(cancellation.Token);
     }
 
-    public abstract string DisplayName { get; }
-
     private TimeSpan ElapsedSinceRefresh => _timeProvider.GetElapsedTime(_lastRefreshTimeStamp);
 
     protected string ServiceName { get; }
 
     protected abstract double RetryBackOffFactor { get; }
+
     protected abstract TimeSpan MinRetryPeriod { get; }
+
     protected abstract TimeSpan MaxRetryPeriod { get; }
+
     protected abstract TimeSpan DefaultRefreshPeriod { get; }
+
     protected CancellationToken ShutdownToken => _disposeCancellation.Token;
 
     /// <inheritdoc/>
@@ -116,7 +118,9 @@ private async Task ResolveAsyncInternal()
     }
 
     protected void SetException(Exception exception) => SetResult(endPoints: null, exception, validityPeriod: TimeSpan.Zero);
+
     protected void SetResult(List<ServiceEndPoint> endPoints, TimeSpan validityPeriod) => SetResult(endPoints, exception: null, validityPeriod);
+
     private void SetResult(List<ServiceEndPoint>? endPoints, Exception? exception, TimeSpan validityPeriod)
     {
         lock (_lock)

src/Microsoft.Extensions.ServiceDiscovery.Dns/DnsSrvServiceEndPointResolver.cs

@@ -20,11 +20,14 @@ internal sealed partial class DnsSrvServiceEndPointResolver(
     TimeProvider timeProvider) : DnsServiceEndPointResolverBase(serviceName, logger, timeProvider), IHostNameFeature
 {
     protected override double RetryBackOffFactor => options.CurrentValue.RetryBackOffFactor;
+
     protected override TimeSpan MinRetryPeriod => options.CurrentValue.MinRetryPeriod;
+
     protected override TimeSpan MaxRetryPeriod => options.CurrentValue.MaxRetryPeriod;
+
     protected override TimeSpan DefaultRefreshPeriod => options.CurrentValue.DefaultRefreshPeriod;
 
-    public override string DisplayName => "DNS SRV";
+    public override string ToString() => "DNS SRV";
 
     string IHostNameFeature.HostName => hostName;
 

src/Microsoft.Extensions.ServiceDiscovery/Configuration/ConfigurationServiceEndPointResolver.cs

@@ -49,9 +49,6 @@ public ConfigurationServiceEndPointResolver(
         _options = options;
     }
 
-    /// <inheritdoc/>
-    public string DisplayName => "Configuration";
-
     /// <inheritdoc/>
     public ValueTask DisposeAsync() => default;
 

src/Microsoft.Extensions.ServiceDiscovery/PassThrough/PassThroughServiceEndPointResolver.cs

@@ -12,8 +12,6 @@ namespace Microsoft.Extensions.ServiceDiscovery.PassThrough;
 /// </summary>
 internal sealed partial class PassThroughServiceEndPointResolver(ILogger logger, string serviceName, EndPoint endPoint) : IServiceEndPointResolver
 {
-    public string DisplayName => "Pass-through";
-
     public ValueTask<ResolutionStatus> ResolveAsync(ServiceEndPointCollectionSource endPoints, CancellationToken cancellationToken)
     {
         if (endPoints.EndPoints.Count != 0)
@@ -29,4 +27,6 @@ public ValueTask<ResolutionStatus> ResolveAsync(ServiceEndPointCollectionSource
     }
 
     public ValueTask DisposeAsync() => default;
+
+    public override string ToString() => "Pass-through";
 }

src/Microsoft.Extensions.ServiceDiscovery/ServiceEndPointResolver.Log.cs

@@ -30,7 +30,7 @@ static string GetEndPointString(ServiceEndPoint ep)
             {
                 if (ep.Features.Get<IServiceEndPointResolver>() is { } resolver)
                 {
-                    return $"{ep.GetEndPointString()} ({resolver.DisplayName})";
+                    return $"{ep.GetEndPointString()} ({resolver})";
                 }
 
                 return ep.GetEndPointString();

src/Microsoft.Extensions.ServiceDiscovery/ServiceEndPointResolverFactory.Log.cs

@@ -16,7 +16,7 @@ public static void CreatingResolver(ILogger logger, string serviceName, List<ISe
         {
             if (logger.IsEnabled(LogLevel.Debug))
             {
-                ServiceEndPointResolverListCore(logger, serviceName, resolvers.Count, string.Join(", ", resolvers.Select(static r => r.DisplayName)));
+                ServiceEndPointResolverListCore(logger, serviceName, resolvers.Count, string.Join(", ", resolvers.Select(static r => r.ToString())));
             }
         }
     }

tests/Microsoft.Extensions.ServiceDiscovery.Tests/ServiceEndPointResolverTests.cs

@@ -77,8 +77,6 @@ public bool TryCreateResolver(string serviceName, [NotNullWhen(true)] out IServi
 
     private sealed class FakeEndPointResolver(Func<ServiceEndPointCollectionSource, CancellationToken, ValueTask<ResolutionStatus>> resolveAsync, Func<ValueTask> disposeAsync) : IServiceEndPointResolver
     {
-        public string DisplayName => "Fake";
-
         public ValueTask<ResolutionStatus> ResolveAsync(ServiceEndPointCollectionSource endPoints, CancellationToken cancellationToken) => resolveAsync(endPoints, cancellationToken);
         public ValueTask DisposeAsync() => disposeAsync();
     }