Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line is specific to aspnet core, and not even sure it's required anymore.
Had to deal with it during the holidays. If you look at all the other dotnet repos they don't have it. It's supposed to allow azdo to authenticate to the feeds (all the upstream ones) using the tokens configured in azdo. But these are public and shouldn't require auth. That's what I understood.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wtgodbe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebastienros not exactly. other repos don't do this b/c they don't use
npm
oryarn
. and, auth is for updating the feed when an authorized person like you grabs packages from the upstream feed and updates lock filesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javier told me 2 weeks ago and I already had forgotten.
So I believe we don't need that here. There is nothing that requires the feed to be updated (packages.lock file), right @eerhardt ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just following the docs from the error: https://aka.ms/cfs/npm. See
Mitigation Steps
section.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged what I had to unblock the supply chain validation. We can tweak this as we go.