-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change outgoing request to arrow in trace span #1684
Change outgoing request to arrow in trace span #1684
Conversation
… peer icon to arrow bounce
I like the idea of using a different arrow to represent uninstrumented hops. Not 100% sure of the bounce arrow though. Are there other arrow options available? |
@DamianEdwards you can find all options here by searching |
@adamint yeah that's exactly what I was thinking too. I like that one for this use case. |
Maybe not very serious but I was thinking about something similar to a shrug emoji to signal that the call is not instrumented 😅 |
|
I prefer the old icon in two places. I used it in the mockup to show that a request is being made to the server, regardless of whether it is a request to an instrumented server or a request to an uninstrumented server. Another problem with new icons in this PR is they don't show the color well. Why do we want different icons? If we do want different icons then I'd prefer the old outbound arrow icon to remain unchanged, and the new icon to the left to be some kind of server icon. |
I'm confused at
This is the same icon as in your mockup. I do think it's worth keeping the instrumented / uninstrumented call icon separate, as they are different kinds of requests. I prefer keeping the icons the same as in PR, though I think we are both expressing a subjecrtive preference. I can ensure the padding is consistent, but otherwise I think this is good. |
This one: I used an arrow will a solid background color on purpose, so it was easy to see the color.
I think I'm ok with them being different, but I'd like to find good icons. |
How about this: For servers, we use the server icon: And continue to use I like this solution because I think in the future, we will use different icons based on the server type. e.g. web server would use server, DB server icon for SQL server/Postgres/etc. |
Oooo why can't we just make that change now! I love that idea. I think we already have the needed details to know whether it's a DATA call or otherwise right? Could we do a mock-up of what it would look like if we did what you're proposing? |
It should be simple to do for the upcoming release. I'd like to get an icon displayed there correctly in this PR. Then we can play with customizing the server icons in a follow up.
Yeah. We know HTTP vs database vs redis vs whatever. Making the change would probably be as easy as doing a mock up. |
Logged an issue : #1725 for @JamesNK suggestion : #1684 (comment) and approving PR. |
Changes the trace bar into
ArrowCircleRight
icon for outgoing requests, as well as changes the uninstrumented peer icon fromArrowCircleRight
toArrowBounce
(the fact that it's an outgoing request is also captured by its parent's icon)resolves #1675
Microsoft Reviewers: Open in CodeFlow