Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from microsoft/usvc-apiserver #1599

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 8, 2024

This pull request updates the following dependencies

From https://github.com/microsoft/usvc-apiserver

  • Subscription: 852f69a6-643d-499a-6cb6-08dbca4ebb98
  • Build: 0.1.46
  • Date Produced: January 8, 2024 7:44:28 PM UTC
  • Commit: 10caa62514311b78e4d8a85a25559d31fc5f17f0
  • Branch: refs/heads/production
Microsoft Reviewers: Open in CodeFlow

…build 0.1.46

Microsoft.DeveloperControlPlane.darwin-amd64 , Microsoft.DeveloperControlPlane.darwin-arm64 , Microsoft.DeveloperControlPlane.linux-amd64 , Microsoft.DeveloperControlPlane.linux-arm64 , Microsoft.DeveloperControlPlane.windows-386 , Microsoft.DeveloperControlPlane.windows-amd64 , Microsoft.DeveloperControlPlane.windows-arm64
 From Version 0.1.45 -> To Version 0.1.46
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jan 8, 2024
@danegsta danegsta merged commit db906a0 into main Jan 9, 2024
9 checks passed
@danegsta danegsta deleted the darc-main-807a26a6-79b3-430a-9b43-c0a89858af68 branch January 9, 2024 18:07
@davidfowl
Copy link
Member

Does this have the proxy changes?

@dnegstad
Copy link

The proxy changes merged this morning; this is a related fix for an error installing the workload on Mac/Linux with those changes.

@dnegstad
Copy link

Ah, wrong PR; yes, this is the proxy change.

@davidfowl
Copy link
Member

cc @balachir the latest builds have the proxy changes. @dnegstad Are you going to send the PR that undoes that complex http client logic in p2?

@davidfowl
Copy link
Member

@karolz-ms @dnegstad I thought the errors on startup would go away with the custom proxy:

image

@karolz-ms
Copy link
Member

I thought this one is related to Azure connectivity and is unrelated to the proxy? @eerhardt ?

@davidfowl
Copy link
Member

There's no azure in this sample, its all local proxies (its talking to rabbitmq)

@eerhardt eerhardt mentioned this pull request Jan 10, 2024
@eerhardt
Copy link
Member

I've submitted #1628 to re-add logging for Redis. This was the change blocked on the proxy issue. With that change I am not seeing errors on startup with the Redis connections.

Looking now why we are seeing it with RabbitMQ. My guess is that RabbitMQ takes that much longer to startup, and our proxy is closing the connection.

@davidfowl
Copy link
Member

I would guess that too, @karolz-ms is there some fixed timeout that the proxy connection has?

@karolz-ms
Copy link
Member

If there is no backed to serve the request, the proxy will not drop the connection. But if there is a backend, the timeout to connect is 5 seconds. From a cursory glance at RabbitMQ container logs it looks like it takes the container longer than that to start serving incoming traffic.

@karolz-ms
Copy link
Member

karolz-ms commented Jan 10, 2024

@eerhardt if you indeed see that the proxy is closing the connection, LMK. I can change its behavior so that it keeps trying to connect till it succeeds (or till the client gives up waiting for the response).

EDIT: double checked the code and the proxy is supposed to do that already. So LMK what you find. My bet is the RabbitMQ client is giving up after not receiving a response.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants