-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from microsoft/usvc-apiserver #1599
Conversation
…build 0.1.46 Microsoft.DeveloperControlPlane.darwin-amd64 , Microsoft.DeveloperControlPlane.darwin-arm64 , Microsoft.DeveloperControlPlane.linux-amd64 , Microsoft.DeveloperControlPlane.linux-arm64 , Microsoft.DeveloperControlPlane.windows-386 , Microsoft.DeveloperControlPlane.windows-amd64 , Microsoft.DeveloperControlPlane.windows-arm64 From Version 0.1.45 -> To Version 0.1.46
Does this have the proxy changes? |
The proxy changes merged this morning; this is a related fix for an error installing the workload on Mac/Linux with those changes. |
Ah, wrong PR; yes, this is the proxy change. |
@karolz-ms @dnegstad I thought the errors on startup would go away with the custom proxy: |
I thought this one is related to Azure connectivity and is unrelated to the proxy? @eerhardt ? |
There's no azure in this sample, its all local proxies (its talking to rabbitmq) |
I've submitted #1628 to re-add logging for Redis. This was the change blocked on the proxy issue. With that change I am not seeing errors on startup with the Redis connections. Looking now why we are seeing it with RabbitMQ. My guess is that RabbitMQ takes that much longer to startup, and our proxy is closing the connection. |
I would guess that too, @karolz-ms is there some fixed timeout that the proxy connection has? |
If there is no backed to serve the request, the proxy will not drop the connection. But if there is a backend, the timeout to connect is 5 seconds. From a cursory glance at RabbitMQ container logs it looks like it takes the container longer than that to start serving incoming traffic. |
@eerhardt if you indeed see that the proxy is closing the connection, LMK. I can change its behavior so that it keeps trying to connect till it succeeds (or till the client gives up waiting for the response). EDIT: double checked the code and the proxy is supposed to do that already. So LMK what you find. My bet is the RabbitMQ client is giving up after not receiving a response. |
This pull request updates the following dependencies
From https://github.com/microsoft/usvc-apiserver
Microsoft Reviewers: Open in CodeFlow