Enable DAPR to work with services listening on addresses different from localhost #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
philliphoff
reviewed
Jan 8, 2024
src/Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs
Outdated
Show resolved
Hide resolved
karolz-ms
force-pushed
the
dev/karolz/dapr-non-localhost
branch
from
c07169a
to
6de62ae
Compare
philliphoff
approved these changes
Jan 10, 2024
|
@davidfowl @mitchdenny can one of you take a look and approve if good? Looks like @philliphoff review is not sufficient... |
davidfowl
approved these changes
Jan 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGRE YET
This requires new DCP version with support for
addressForandaddressForServingtemplate functions (ETA ~ second week of January). Just want to get feedback about this change at this point.Microsoft Reviewers: Open in CodeFlow
UPDATE: the relevant DCP change has been merged, so this is good to go