Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old/broken links #148

Merged
merged 1 commit into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,4 @@ Follow instructions in [docs/getting-started.md](docs/getting-started.md)

# Contributing

If you need write access to the repo, please join the [astra-push team](https://repos.opensource.microsoft.com/orgs/dotnet/teams/astra-push/).

This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [[email protected]](mailto:[email protected]) with any additional questions or comments.
6 changes: 3 additions & 3 deletions eng/pipelines/azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ stages:
- stage: build
displayName: Build
jobs:
# TODO: Temporarily disabled, see:https://github.com/dotnet/astra/issues/110
# TODO: Temporarily disabled, see:https://github.com/dotnet/aspire/issues/145
# - ${{ if and(eq(variables._RunAsInternal, True), notin(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.SourceBranch'], 'refs/heads/main')) }}:
# - template: /eng/common/templates/job/onelocbuild.yml
# parameters:
# MirrorRepo: astra
# MirrorRepo: aspire
# LclSource: lclFilesFromPackage
# LclPackageId: 'LCL-JUNO-PROD-ASTRA'
# LclPackageId: 'LCL-JUNO-PROD-ASPIRE'
- template: /eng/common/templates/jobs/jobs.yml
parameters:
artifacts:
Expand Down
4 changes: 1 addition & 3 deletions src/Aspire.Hosting.Sdk/SDK/Sdk.in.targets
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,10 @@
<ItemGroup>
<ProjectCapability Include="Aspire" />
<ProjectCapability Include="AspireHost" />
<!-- TODO: remove this once VS supports the new name. -->
<ProjectCapability Include="Astra" />
</ItemGroup>

<PropertyGroup>
<!-- Aspire hosting projects aren't publishable right now until https://github.com/dotnet/astra/issues/268 is good -->
<!-- Aspire hosting projects aren't publishable right now until https://github.com/dotnet/aspire/issues/147 is good -->
<IsPublishable Condition="'$(IsPublishable)' == ''">false</IsPublishable>
<IsPackable Condition="'$(IsPackable)' == ''">false</IsPackable>
</PropertyGroup>
Expand Down
4 changes: 1 addition & 3 deletions src/Aspire.Hosting/build/Aspire.Hosting.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<IsDistributedApplicationHost Condition="'$(IsDistributedApplicationHost)' == ''">true</IsDistributedApplicationHost>
<IsAspireHost Condition="'$(IsAspireHost)' == ''">true</IsAspireHost>
<!-- Aspire hosting projects aren't publishable right now until https://github.com/dotnet/astra/issues/268 is good -->
<!-- Aspire hosting projects aren't publishable right now until https://github.com/dotnet/aspire/issues/147 is good -->
<IsPublishable Condition="'$(IsPublishable)' == ''">false</IsPublishable>
<IsPackable Condition="'$(IsPackable)' == ''">false</IsPackable>
</PropertyGroup>
Expand All @@ -20,8 +20,6 @@

<ItemGroup>
<ProjectCapability Include="Aspire" />
<!-- TODO: remove this once VS supports the new name. -->
<ProjectCapability Include="Astra" />
eerhardt marked this conversation as resolved.
Show resolved Hide resolved
</ItemGroup>

<Import Sdk="Microsoft.NET.Sdk.StaticWebAssets" Project="Sdk.props" />
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Aspire.Azure.Data.Tables/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,4 @@ You can also setup the [TableClientOptions](https://learn.microsoft.com/dotnet/a

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,5 @@ You can also setup the [ServiceBusClientOptions](https://learn.microsoft.com/dot

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire

2 changes: 1 addition & 1 deletion src/Components/Aspire.Azure.Security.KeyVault/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,4 @@ You can also setup the [SecretClientOptions](https://learn.microsoft.com/dotnet/

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
2 changes: 1 addition & 1 deletion src/Components/Aspire.Azure.Storage.Blobs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,4 @@ You can also setup the [BlobClientOptions](https://learn.microsoft.com/dotnet/ap

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
2 changes: 1 addition & 1 deletion src/Components/Aspire.Azure.Storage.Queues/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,4 @@ You can also setup the [QueueClientOptions](https://learn.microsoft.com/dotnet/a

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
2 changes: 1 addition & 1 deletion src/Components/Aspire.Microsoft.Data.SqlClient/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,4 @@ builder.AddSqlServerClient("sqldata");

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@ builder.AddSqlServerDbContext<MyDbContext>("sqldata");

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public static partial class AspireEFPostgreSqlExtensions
if (builder.Environment.IsDevelopment())
{
// calling UseDeveloperExceptionPage is the responsibility of the app, not Component
#pragma warning disable IL3050 // TODO: https://github.com/dotnet/astra/issues/88 should remove this line
#pragma warning disable IL3050 // TODO: https://github.com/dotnet/aspire/issues/146 should remove this line
builder.Services.AddDatabaseDeveloperPageExceptionFilter();
#pragma warning restore IL3050
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,4 @@ builder.AddNpgsqlDbContext<MyDbContext>("postgresdb");

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
2 changes: 1 addition & 1 deletion src/Components/Aspire.Npgsql/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,4 @@ builder.AddNpgsqlDataSource("postgresdb");

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,4 @@ builder.AddRedisDistributedCache("cache");

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,4 @@ builder.AddRedisOutputCache("cache");

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire
2 changes: 1 addition & 1 deletion src/Components/Aspire.StackExchange.Redis/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,4 @@ builder.AddRedis("cache");

## Feedback & Contributing

https://github.com/dotnet/astra
https://github.com/dotnet/aspire