Support passing the endpoint env into containers #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-codeflow
|
Seems straightforward enough. What's missing from making this ready for review/consideration in preview.2? Tests? |
Yes, tests. I'll probably do a basic test that makes sure things are set and manual end to end test. |
mitchdenny
approved these changes
Dec 17, 2023
|
/backport to release/8.0-preview2 |
|
Started backporting to release/8.0-preview2: https://github.com/dotnet/aspire/actions/runs/7237470556 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to improve the testing and functionality of the codebase. The most important changes include adding new test methods to verify the correct setup of service bindings with container ports and environment variables, and modifying the
ApplicationExecutor.csfile to correctly inject environment variables for services produced by an executable resource.Testing improvements:
tests/Aspire.Hosting.Tests/WithServiceBindingTests.cs: Added a new test method to verify the correct addition of a service binding with a container port and environment variable.tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs: Added a new test method to verify that a specified environment variable is correctly set in a service binding.Code functionality improvements:
src/Aspire.Hosting/Dcp/ApplicationExecutor.cs: Added a new private methodInjectPortEnvVarsto inject environment variables for services produced by an executable resource. ModifiedApplyLaunchProfileandCreateExecutablesAsyncto callInjectPortEnvVarsto ensure the environment variables are injected into the configuration dictionary. [1] [2] [3]Configuration improvements:
src/Aspire.Hosting/Extensions/ContainerResourceBuilderExtensions.cs: Modified theAddContainerandWithServiceBindingextension methods to include an additional parameter for specifying the name of the environment variable to inject.Fixes #1430
Microsoft Reviewers: Open in CodeFlow