Simplify ResourcePublisher #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We publish updates to resources via `IAsyncEnumerable<ResourceChange>`. The previous code defined a custom enumerable/enumerator for this, but it's possible to use a generator function instead and reduce the amount of code a bit.
drewnoakes
force-pushed
the
simplify-resource-publisher
branch
from
30c7696
to
3b83704
Compare
JamesNK
approved these changes
Dec 12, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
It's more consistent with the other enum member, named Upsert (which should otherwise be Upserted).
|
@JamesNK I added |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We publish updates to resources via
IAsyncEnumerable<ResourceChange>. The previous code defined a custom enumerable/enumerator for this, but it's possible to use a generator function instead and reduce the amount of code a bit.Microsoft Reviewers: Open in CodeFlow