Disable "spec only" button when it doesn't do anything #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variables window has a toggle button that controls whether only variables "from spec" are shown or not. This change hides the button in the case that all items _are_ from the spec, in which case toggling it would have no visible effect.
|
I would advocate for disabling the button instead of hiding it completely. |
|
Agreed - from an accessibility perspective disabled is better in this scenario. |
|
Updated to disable rather than hide the button. |
drewnoakes
changed the title
tlmii
reviewed
Dec 10, 2023
tlmii
approved these changes
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variables window has a toggle button that controls whether only "from spec" variables are shown.
This change disables the button in the case that all items are from the spec, in which case toggling it would have no visible effect.