Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if dapr path exists, throw exception if it doesnt #1251

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Test if dapr path exists, throw exception if it doesnt #1251

merged 7 commits into from
Jan 3, 2024

Conversation

onionhammer
Copy link
Contributor

Addresses #1211

Also adds method where more possible dapr paths can be added

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Dec 6, 2023
@DamianEdwards DamianEdwards reopened this Dec 8, 2023
@joperezr joperezr added the community-contribution Indicates that the PR has been added by a community member label Dec 11, 2023
@onionhammer
Copy link
Contributor Author

@philliphoff what's the status on this? Do you need anything from me?

@davidfowl
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

philliphoff
philliphoff approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danmoseley
Copy link
Member

@philliphoff can we merge this ? I'll rerun validation

@danmoseley danmoseley closed this Jan 2, 2024
@danmoseley danmoseley reopened this Jan 2, 2024
@philliphoff
Copy link
Contributor

@danmoseley Yes, assuming validation passes, please merge.

@danmoseley danmoseley merged commit 9ffacd9 into dotnet:main Jan 3, 2024
10 checks passed
@danmoseley
Copy link
Member

thanks @onionhammer !

@philliphoff philliphoff mentioned this pull request Jan 11, 2024
Closed
@onionhammer onionhammer deleted the more-dapr-paths branch January 11, 2024 16:32
@onionhammer
Copy link
Contributor Author

Boo, scrubbed from the release notes :P

@davidfowl
Copy link
Member

We can fix that 😄

@joperezr ?

@joperezr
Copy link
Member

So sorry about that @onionhammer, we used the automatic Generate Notes feature from GitHub, and while it did list out your PR it didn't listed you for some reason in the New contributors list, I've manually fixed that now :)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philliphoff philliphoff philliphoff approved these changes

@davidfowl davidfowl davidfowl approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@onionhammer @davidfowl @danmoseley @philliphoff @joperezr @DamianEdwards