Make some types non-generic #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
force-pushed
the
non-generic
branch
2 times, most recently
from
a91f594
to
7019186
Compare
Three types are made non-generic, as we no longer specialise by resource type: - ViewModelProcessor - ViewModelMonitor - ResourceChange
drewnoakes
force-pushed
the
non-generic
branch
from
7019186
to
3069545
Compare
|
Do we have any future plans that would require these generics? That's not clear in your description. |
|
The view model types are being moved towards a uniform representation, so that the UI doesn't need to know anything about specific resource types (container, exe, project, ...), leaving the set open to extension, and making it easier to program against them all uniformly. |
adamint
approved these changes
Dec 6, 2023
tlmii
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three types are made non-generic, as we no longer specialise by resource type: