App model rework around resource types and connection string emission for containers #1165

mitchdenny · 2023-12-01T09:29:16Z

This PR is a fairly major change to all the resource types built into Aspire.Hosting to support a model where calls like AddRedisContainer actually outputs a container resource to the manifest (container.v0) with enough configuration such that it can run within a given orchestrator.

It introduces three new key concepts:

Container resources can now explicitly declare a connectionString field in the manifest. When a resource connection string is referenced this field can be used.
Because the content of connectionString cannot be determined at manifest publishing time it now contains placeholder values that the deployment tool is expected to process and replace as appropriate.
There is a new per resource field inputs (optional) which tells the deployment tool when it should prompt the user (or generate) inputs such as a password.

The following JSON manifest is produces from tests/testproject/TestProject.AppHost and contains the built-in resource types that employ this model.

Note that as part of this change, we have removed AddXYZConnection(...) methods and associated resource types as we found they added minimal value beyond just adding an environment variable. Also note that we've added a non-container version of most of the resource types (e.g. AddRedis(...) vs. AddRedisContainer(...)). Locally these methods do much the same thing, but when the manifest is produced the first option does not produce a container.v0 resource, it produces redis.v0 like it previously did.

Ideally folks will use these more abstract builder methods (e.g. AddRedis(...)) instead of the container orientated counterpart. Deployment tools that target cloud environments should preference the use of managed services with better operational support, particularly in production deployment scenarios.

Deployment tools may wish to warn users that they are using container builder methods vs. abstract resource type builder methods when deploying to production, although the containerized versions should still continue to work.

{
  "resources": {
    "servicea": {
      "type": "project.v0",
      "path": "../TestProject.ServiceA/TestProject.ServiceA.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        },
        "https": {
          "scheme": "https",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    },
    "serviceb": {
      "type": "project.v0",
      "path": "../TestProject.ServiceB/TestProject.ServiceB.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        },
        "https": {
          "scheme": "https",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    },
    "servicec": {
      "type": "project.v0",
      "path": "../TestProject.ServiceC/TestProject.ServiceC.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        },
        "https": {
          "scheme": "https",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    },
    "workera": {
      "type": "project.v0",
      "path": "../TestProject.WorkerA/TestProject.WorkerA.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true"
      }
    },
    "nodeapp": {
      "type": "executable.v0",
      "workingDirectory": "../nodeapp",
      "command": "node",
      "args": [
        "C:\\Code\\dotnet\\aspire\\tests\\testproject\\TestProject.AppHost\\..\\nodeapp\\app.js"
      ],
      "env": {
        "NODE_ENV": "production",
        "PORT": "{nodeapp.bindings.http.port}"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    },
    "npmapp": {
      "type": "executable.v0",
      "workingDirectory": "../nodeapp",
      "command": "npm",
      "args": [
        "run",
        "start"
      ],
      "env": {
        "NODE_ENV": "production",
        "PORT": "{npmapp.bindings.http.port}"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    },
    "sqlservercontainer": {
      "type": "container.v0",
      "image": "mcr.microsoft.com/mssql/server:2022-latest",
      "env": {
        "ACCEPT_EULA": "Y",
        "MSSQL_SA_PASSWORD": "{sqlservercontainer.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 1433
        }
      },
      "connectionString": "Server={sqlservercontainer.bindings.tcp.host},{sqlservercontainer.bindings.tcp.port};User ID=sa;Password={sqlservercontainer.inputs.password};TrustServerCertificate=true;",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "mysqlcontainer": {
      "type": "container.v0",
      "image": "mysql:latest",
      "env": {
        "MYSQL_ROOT_PASSWORD": "{mysqlcontainer.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 3306
        }
      },
      "connectionString": "Server={mysqlcontainer.bindings.tcp.host};Port={mysqlcontainer.bindings.tcp.port};User ID=root;Password={mysqlcontainer.inputs.password}",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "rediscontainer": {
      "type": "container.v0",
      "image": "redis:latest",
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 6379
        }
      },
      "connectionString": "{rediscontainer.bindings.tcp.host}:{rediscontainer.bindings.tcp.port}"
    },
    "postgrescontainer": {
      "type": "container.v0",
      "image": "postgres:latest",
      "env": {
        "POSTGRES_HOST_AUTH_METHOD": "scram-sha-256",
        "POSTGRES_INITDB_ARGS": "--auth-host=scram-sha-256 --auth-local=scram-sha-256",
        "POSTGRES_PASSWORD": "{postgrescontainer.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 5432
        }
      },
      "connectionString": "Host={postgrescontainer.bindings.tcp.host};Port={postgrescontainer.bindings.tcp.port};Username=postgres;Password={postgrescontainer.inputs.password};",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "rabbitmqcontainer": {
      "type": "container.v0",
      "image": "rabbitmq:3-management",
      "env": {
        "RABBITMQ_DEFAULT_USER": "guest",
        "RABBITMQ_DEFAULT_PASS": "{rabbitmqcontainer.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 5672
        },
        "management": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http",
          "containerPort": 15672
        }
      },
      "connectionString": "amqp://guest:{rabbitmqcontainer.inputs.password}@{rabbitmqcontainer.bindings.management.host}:{rabbitmqcontainer.bindings.management.port}",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "mongodbcontainer": {
      "type": "container.v0",
      "image": "mongo:latest",
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 27017
        }
      },
      "connectionString": "{mongodbcontainer.bindings.tcp.host}:{mongodbcontainer.bindings.tcp.port}"
    },
    "sqlserverabstract": {
      "type": "container.v0",
      "image": "mcr.microsoft.com/mssql/server:2022-latest",
      "env": {
        "ACCEPT_EULA": "Y",
        "MSSQL_SA_PASSWORD": "{sqlserverabstract.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 1433
        }
      },
      "connectionString": "Server={sqlserverabstract.bindings.tcp.host},{sqlserverabstract.bindings.tcp.port};User ID=sa;Password={sqlserverabstract.inputs.password};TrustServerCertificate=true;",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "mysqlabstract": {
      "type": "container.v0",
      "image": "mysql:latest",
      "env": {
        "MYSQL_ROOT_PASSWORD": "{mysqlabstract.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 3306
        }
      },
      "connectionString": "Server={mysqlabstract.bindings.tcp.host};Port={mysqlabstract.bindings.tcp.port};User ID=root;Password={mysqlabstract.inputs.password}",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "redisabstract": {
      "type": "container.v0",
      "image": "redis:latest",
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 6379
        }
      },
      "connectionString": "{redisabstract.bindings.tcp.host}:{redisabstract.bindings.tcp.port}"
    },
    "postgresabstract": {
      "type": "container.v0",
      "image": "postgres:latest",
      "env": {
        "POSTGRES_HOST_AUTH_METHOD": "scram-sha-256",
        "POSTGRES_INITDB_ARGS": "--auth-host=scram-sha-256 --auth-local=scram-sha-256",
        "POSTGRES_PASSWORD": "{postgresabstract.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 5432
        }
      },
      "connectionString": "Host={postgresabstract.bindings.tcp.host};Port={postgresabstract.bindings.tcp.port};Username=postgres;Password={postgresabstract.inputs.password};",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "rabbitmqabstract": {
      "type": "container.v0",
      "image": "rabbitmq:3-management",
      "env": {
        "RABBITMQ_DEFAULT_USER": "guest",
        "RABBITMQ_DEFAULT_PASS": "{rabbitmqabstract.inputs.password}"
      },
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 5672
        },
        "management": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http",
          "containerPort": 15672
        }
      },
      "connectionString": "amqp://guest:{rabbitmqabstract.inputs.password}@{rabbitmqabstract.bindings.management.host}:{rabbitmqabstract.bindings.management.port}",
      "inputs": {
        "password": {
          "type": "string",
          "secret": true,
          "default": {
            "generate": {
              "minLength": 10
            }
          }
        }
      }
    },
    "mongodbabstract": {
      "type": "mongodb.server.v0"
    },
    "integrationservicea": {
      "type": "project.v0",
      "path": "../TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj",
      "env": {
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES": "true",
        "OTEL_DOTNET_EXPERIMENTAL_OTLP_EMIT_EVENT_LOG_ATTRIBUTES": "true",
        "ConnectionStrings__sqlservercontainer": "{sqlservercontainer.connectionString}",
        "ConnectionStrings__mysqlcontainer": "{mysqlcontainer.connectionString}",
        "ConnectionStrings__rediscontainer": "{rediscontainer.connectionString}",
        "ConnectionStrings__postgrescontainer": "{postgrescontainer.connectionString}",
        "ConnectionStrings__rabbitmqcontainer": "{rabbitmqcontainer.connectionString}",
        "ConnectionStrings__mongodbcontainer": "{mongodbcontainer.connectionString}",
        "ConnectionStrings__sqlserverabstract": "{sqlserverabstract.connectionString}",
        "ConnectionStrings__mysqlabstract": "{mysqlabstract.connectionString}",
        "ConnectionStrings__redisabstract": "{redisabstract.connectionString}",
        "ConnectionStrings__postgresabstract": "{postgresabstract.connectionString}",
        "ConnectionStrings__rabbitmqabstract": "{rabbitmqabstract.connectionString}",
        "ConnectionStrings__mongodbabstract": "{mongodbabstract.connectionString}"
      },
      "bindings": {
        "http": {
          "scheme": "http",
          "protocol": "tcp",
          "transport": "http"
        },
        "https": {
          "scheme": "https",
          "protocol": "tcp",
          "transport": "http"
        }
      }
    }
  }
}

mitchdenny · 2023-12-01T09:34:27Z

ping @ellismg @davidfowl @prom3theu5

samples/eShopLite/AppHost/aspire-manifest.json

mitchdenny · 2023-12-05T07:53:02Z

Made some changes for Postgres. Specifically, we no longer use the trust auth method either locally for for inner loop. Instead with use the scram-sha-256 password exchange method. It stops the password being transmitted via clear text (using a challenge mechanism). The connection still isn't TLS though - but its better than auth mode being trust if someone is deploying onto an internal container network.

src/Aspire.Hosting/Postgres/PostgresBuilderExtensions.cs

Co-authored-by: Eric Erhardt <[email protected]>

…into abstract-resources

mitchdenny · 2023-12-06T10:47:42Z

@davidfowl @ellismg @prom3theu5 ... big push! Let me hear your thoughts and feedback.

davidfowl · 2023-12-06T16:37:29Z

Why does the nodeapp have the full physical path to app.js, that seems broken. Are we resolving the full path and putting it in args? I'll look into that.

One thing we should consider is not having containers require a custom manifest but instead using annotations. That would let the manifest writing happen without so much custom logic in each container (I worry about the amount of copy pasta required for new containers)

prom3theu5 · 2023-12-06T16:49:30Z

It does look better now.

Quite a lot of rework in aspirate for third party component support for things like Postgres and Redis now though, but hopefully the amount of data about what comprises a container in the manifest is enough to construct custom deployments for them etc

The different there is when using the component type it was each to have a custom processor for that component that pulled separate templates for the components.

So for redis it deployed a stateful set of a standard redis instance based on a separate template. for Postgres it wasn't a stateful set but a deployment with custom health checks etc, and the "processors" were handled by the component type.

I'll make it work though, I agree this is a change for the better.

davidfowl · 2023-12-06T17:00:01Z

Quite a lot of rework in aspirate for third party component support for things like Postgres and Redis now though, but hopefully the amount of data about what comprises a container in the manifest is enough to construct custom deployments for them etc

Why? Those resources are still abstract resources that the deployment tool needs to handle. This PR just makes container resources more explanatory.

davidfowl · 2023-12-06T17:01:55Z

@mitchdenny do you plan to update the templates to use AddRedis instead of AddRedisContainer?

prom3theu5 · 2023-12-06T17:39:56Z

Just because of how I implemented components is all

Each component had its own processor like https://github.com/prom3theu5/aspirational-manifests/blob/main/src/Aspirate.Processors/Redis/RedisProcessor.cs

I agree it simplifies a lot of that just needs a more “intelligent” processor for the container type.

The way I implemented component types was with their own processors and own set of templates so the processor for redis It explicitly chose a redis template with lower resource limits set etc. now each type will just be container.v0

https://github.com/prom3theu5/aspirational-manifests/blob/main/src/Aspirate.Cli/Templates/redis.hbs

I can use the type to control the selection of which template. Now on a container if you change the custom image for redis to joeblogs:about-stuff there is no way to know that it's redis.

Components like redis don't technically need a service as well as a deployment defining.

Don't worry. I'll just produce a container processor and rework all the custom templates into one unified templated template. Worst case everything will just end up with a matching service.

Besides this container type is in addition to the other resource types isn't it?
So it's technically not a rework just another resource type that produces a fully custom deployment.

mitchdenny · 2023-12-06T20:07:14Z

@davidfowl up for discussion. I think it would prefer to use the non container variants.

@prom3theu5 keep your existing logic for redis etc, those resource types still exist. The sample should be updated to use them.

mitchdenny · 2023-12-06T21:59:28Z

@davidfowl template updated.

@prom3theu5 I've updated the sample AppHost to go back to using the abstract resource types (AddRedis instead of AddRedisContainer). This means the sample manifest outputs the following which should be exactly the same as what you are used to dealing with:

{
  "resources": {
    "postgres": {
      "type": "postgres.server.v0"
    },
    "catalogdb": {
      "type": "postgres.database.v0",
      "parent": "postgres"
    },
    "basketcache": {
      "type": "redis.v0"
    },
    ...

The changes made in this PR mean that when you do something like AddRedisContainer you'll get this:

{
  "resources": {
    "postgres": {
      "type": "postgres.server.v0"
    },
    "catalogdb": {
      "type": "postgres.database.v0",
      "parent": "postgres"
    },
    "basketcache": {
      "type": "container.v0",
      "image": "redis:latest",
      "bindings": {
        "tcp": {
          "scheme": "tcp",
          "protocol": "tcp",
          "transport": "tcp",
          "containerPort": 6379
        }
      },
      "connectionString": "{basketcache.bindings.tcp.host}:{basketcache.bindings.tcp.port}"
    },
    ...

Note that the basketcache resource which was redis.v0 has been replaced with a regular container.v0 resource. Deployment tools should process these like a regular container (which was already an existing resource). The key difference is the addition of the connectionString field to a container (optiona) and the inputs field (also optional).

mitchdenny · 2023-12-06T22:01:10Z

One thing we should consider is not having containers require a custom manifest but instead using annotations. That would let the manifest writing happen without so much custom logic in each container (I worry about the amount of copy pasta required for new containers)

We are already pretty late, so if you are happy to do so can we defer that to preview 3. I think we would probably need an ManifestInputAnnotation and a ManifestConnectionStringAnnotation.

davidfowl · 2023-12-07T05:50:49Z

We are already pretty late, so if you are happy to do so can we defer that to preview 3. I think we would probably need an ManifestInputAnnotation and a ManifestConnectionStringAnnotation.

Lets file a follow up issue. This needs to be backported to preview2.

Also, this is a breaking change since everyone is using AddRedisContainer today 😄

… for containers (#1165) * Abstract resources and templated connection strings. * Add abstract redis for testing. * Moved MySql to input request model. * Postgres implementation. * Update PostgresBuilderExtensions.cs Co-authored-by: Eric Erhardt <[email protected]> * Migrate RabbitMQ to new model. * Migrate SQL to new model. * Test case updates. * Update mongo resource to the new model. * Update manfiests. * Update template. --------- Co-authored-by: Eric Erhardt <[email protected]>

mitchdenny · 2023-12-07T06:04:01Z

@davidfowl backport PR: #1270

… for containers (#1165) (#1270) * Abstract resources and templated connection strings. * Add abstract redis for testing. * Moved MySql to input request model. * Postgres implementation. * Update PostgresBuilderExtensions.cs * Migrate RabbitMQ to new model. * Migrate SQL to new model. * Test case updates. * Update mongo resource to the new model. * Update manfiests. * Update template. --------- Co-authored-by: Eric Erhardt <[email protected]>

sebastienros · 2023-12-09T01:01:11Z

src/Aspire.Hosting/SqlServer/SqlServerBuilderExtensions.cs

    {
-        var sqlServerConnection = new SqlServerConnectionResource(name, connectionString);
+        var password = Guid.NewGuid().ToString("N") + Guid.NewGuid().ToString("N").ToUpper();


What is the reason to repeat the guid?

The reason to repeat the GUID is that the default password Policy for the SQL container needs upper case and lower case characters with special cases. This is just a cheats way of using GUIDs to do that.

sebastienros · 2023-12-09T01:03:48Z

@mitchdenny The sql client doesn't work anymore after this PR, the password is invalid for sa when resolving SqlConnection. Or is there something else to do than AddDatabase() in the host and AddSqlServerClient in the app?

mitchdenny · 2023-12-09T01:17:41Z

What does your app host look like so I can repro.

mitchdenny · 2023-12-09T04:58:12Z

I am not sure there is a problem here, I just tested it with tests/testprogram/TestProgram.AppHost. Here was my methodology:

Start the app host.
Go to integration service /health endpoint and verify that everything is healthy.
Go to Docker Desktop and stop the SQL server instances (there are two of them)
Hit the health endpoint again ... should now be unhealthy.
Start both containers again ... should eventually go healthy again.

eerhardt · 2023-12-12T15:37:23Z

tests/testproject/TestProject.AppHost/TestProgram.cs

+            var sqlserverAbstract = AppBuilder.AddSqlServerContainer("sqlserverabstract");
+            var mysqlAbstract = AppBuilder.AddMySqlContainer("mysqlabstract");
+            var redisAbstract = AppBuilder.AddRedisContainer("redisabstract");
+            var postgresAbstract = AppBuilder.AddPostgresContainer("postgresabstract");
+            var rabbitmqAbstract = AppBuilder.AddRabbitMQContainer("rabbitmqabstract");
+            var mongodbAbstract = AppBuilder.AddMongoDB("mongodbabstract");


@mitchdenny - were these "Abstract" resources all not supposed to have Container on them? As this stands, this code spins up 2 SQL Server containers in the exact same way. Same for MySql, Redis, Postgres, RabbitMQ.

mitchdenny added 2 commits December 1, 2023 20:13

Abstract resources and templated connection strings.

6545f42

Add abstract redis for testing.

6a12fcb

dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Dec 1, 2023

mitchdenny requested review from davidfowl and ellismg December 1, 2023 09:33

mitchdenny mentioned this pull request Dec 1, 2023

Resources should attempt to describe their connection string format templatized in the manifest #1088

Closed

mitchdenny added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Dec 1, 2023

mitchdenny self-assigned this Dec 1, 2023

mitchdenny added this to the preview 2 (Dec) milestone Dec 1, 2023

This was linked to issues Dec 1, 2023

Container vs. abstract resource rework #1164

Closed

Resources should attempt to describe their connection string format templatized in the manifest #1088

Closed

ellismg reviewed Dec 2, 2023

View reviewed changes

samples/eShopLite/AppHost/aspire-manifest.json Outdated Show resolved Hide resolved

mitchdenny added 3 commits December 5, 2023 11:52

Merge branch 'main' into abstract-resources

7588767

Moved MySql to input request model.

8547b64

Postgres implementation.

a73ae21

eerhardt reviewed Dec 5, 2023

View reviewed changes

src/Aspire.Hosting/Postgres/PostgresBuilderExtensions.cs Outdated Show resolved Hide resolved

mitchdenny and others added 7 commits December 6, 2023 08:57

Update PostgresBuilderExtensions.cs

7f0ca91

Co-authored-by: Eric Erhardt <[email protected]>

Migrate RabbitMQ to new model.

2424c78

Migrate SQL to new model.

2c95c8e

Merge branch 'abstract-resources' of https://github.com/dotnet/aspire …

7a065cc

…into abstract-resources

Test case updates.

09c3a0d

Merge in mongo changes.

3abc870

Update mongo resource to the new model.

6fad802

Update manfiests.

c356c2a

Update template.

d1b2b58

mitchdenny requested review from ellismg and eerhardt December 7, 2023 05:41

davidfowl approved these changes Dec 7, 2023

View reviewed changes

mitchdenny mentioned this pull request Dec 7, 2023

Improve container.v0 connection string / input generation logic via annotations. #1269

Closed

mitchdenny merged commit 1ae3c40 into main Dec 7, 2023
8 checks passed

mitchdenny deleted the abstract-resources branch December 7, 2023 05:59

mitchdenny mentioned this pull request Dec 7, 2023

App model rework around resource types and connection string emission… #1270

Merged

g7ed6e mentioned this pull request Dec 7, 2023

Dcp container reconciler: fail to start container #1257

Closed

sebastienros reviewed Dec 9, 2023

View reviewed changes

eerhardt reviewed Dec 12, 2023

View reviewed changes

github-actions bot locked and limited conversation to collaborators Apr 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App model rework around resource types and connection string emission for containers #1165

App model rework around resource types and connection string emission for containers #1165

mitchdenny commented Dec 1, 2023 •

edited

Loading

mitchdenny commented Dec 1, 2023

mitchdenny commented Dec 5, 2023

mitchdenny commented Dec 6, 2023

davidfowl commented Dec 6, 2023

prom3theu5 commented Dec 6, 2023

davidfowl commented Dec 6, 2023

davidfowl commented Dec 6, 2023

prom3theu5 commented Dec 6, 2023 •

edited

Loading

mitchdenny commented Dec 6, 2023

mitchdenny commented Dec 6, 2023

mitchdenny commented Dec 6, 2023 •

edited

Loading

davidfowl commented Dec 7, 2023

mitchdenny commented Dec 7, 2023

sebastienros Dec 9, 2023

mitchdenny Dec 9, 2023

sebastienros commented Dec 9, 2023

mitchdenny commented Dec 9, 2023

mitchdenny commented Dec 9, 2023

eerhardt Dec 12, 2023

App model rework around resource types and connection string emission for containers #1165

App model rework around resource types and connection string emission for containers #1165

Conversation

mitchdenny commented Dec 1, 2023 • edited Loading

mitchdenny commented Dec 1, 2023

mitchdenny commented Dec 5, 2023

mitchdenny commented Dec 6, 2023

davidfowl commented Dec 6, 2023

prom3theu5 commented Dec 6, 2023

davidfowl commented Dec 6, 2023

davidfowl commented Dec 6, 2023

prom3theu5 commented Dec 6, 2023 • edited Loading

mitchdenny commented Dec 6, 2023

mitchdenny commented Dec 6, 2023

mitchdenny commented Dec 6, 2023 • edited Loading

davidfowl commented Dec 7, 2023

mitchdenny commented Dec 7, 2023

sebastienros Dec 9, 2023

Choose a reason for hiding this comment

mitchdenny Dec 9, 2023

Choose a reason for hiding this comment

sebastienros commented Dec 9, 2023

mitchdenny commented Dec 9, 2023

mitchdenny commented Dec 9, 2023

eerhardt Dec 12, 2023

Choose a reason for hiding this comment

mitchdenny commented Dec 1, 2023 •

edited

Loading

prom3theu5 commented Dec 6, 2023 •

edited

Loading

mitchdenny commented Dec 6, 2023 •

edited

Loading