Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing NuGet package to Azure Key Vault README #1103

Conversation

chrisdcmoore
Copy link
Contributor

Fixes #440

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Nov 29, 2023
Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DamianEdwards DamianEdwards merged commit c6df9c3 into dotnet:main Nov 29, 2023
3 checks passed
@eerhardt
Copy link
Member

Thanks for the contribution, @chrisdcmoore.

Any chance you can update the other 4 Azure components as well? This problem isn't specific to Key Vault.

chrisdcmoore added a commit to chrisdcmoore/aspire that referenced this pull request Nov 30, 2023
@chrisdcmoore
Copy link
Contributor Author

Sure thing - done in #1141 (along with the two Comsos DB READMEs, as I think they also needed it).

eerhardt added a commit that referenced this pull request Dec 7, 2023
* add missing nuget packages to Azure component READMEs

follow-up to #1103

* Update EF Cosmos README to match normal Cosmos README.

---------

Co-authored-by: Eric Erhardt <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update README for Aspire.Azure.Security.KeyVault to require package reference to Aspire.Hosting.Azure
3 participants