Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebToolsE2E][Aspire] On the dashboard, collapse menu list, click the second icon (Monitoring), nothing happens. #1070

Closed
v-cazhang opened this issue Nov 28, 2023 · 9 comments · Fixed by #1249
Assignees

Comments

@v-cazhang
Copy link

REGRESSION INFO: Also repro on 17.9 Preview 1 (includes Aspire.ProjectTemplates.8.0.0-preview.1.23557.2)
INSTALL STEPS

  1. Clean machine: Win11 x64 23h2 ENU
  2. Install latest VS 17.9 P2 from [34327.208.main]
  3. CLI workload update and install aspire workload: [Aspire.ProjectTemplates.8.0.0-preview.2.23577.7]
  4. Apply NuGet Feeds

REPRO STEPS

  1. In the VS, create a new project > .NET Aspire Starter Application > .NET 8.0 > Create.
  2. Ctrl F5.
  3. On the dashboard, collapse the menu list, then click the second icon (Monitoring).

ACTUAL
Click the second icon (Monitoring), nothing happens, selection locator doesn't change, the menu list also doesn't expand.
issue2

EXPECTED
It should expand the 'Monitoring' section.

@tlmii
Copy link
Member

tlmii commented Nov 28, 2023

@vnbaaij I noticed this too (though I rarely collapse). Is there anything we can change now? Any plans to adjust the way this works?

@vnbaaij
Copy link
Contributor

vnbaaij commented Nov 30, 2023

For v4.1.1 I'm adding functionality so the menu itself is collapsed and you click on an item (whether it has a link or not), the menu will go to the expanded state
NavMenuBahaviorChange

@adamint
Copy link
Member

adamint commented Dec 6, 2023

@vnbaaij this is still an issue on 4.1.1, which we are using.

@vnbaaij
Copy link
Contributor

vnbaaij commented Dec 6, 2023

@vnbaaij this is still an issue on 4.1.1, which we are using.

No, the item should now expand as shown in the image in my previous comment

@adamint
Copy link
Member

adamint commented Dec 6, 2023

@vnbaaij I can confirm both that the Aspire Dashboard is using version 4.1.1, and that the behavior is still occurring.

Animation

@tlmii
Copy link
Member

tlmii commented Dec 6, 2023

Yeah I saw it too and was wondering if maybe my branch was just out of date. But I guess not.

@vnbaaij
Copy link
Contributor

vnbaaij commented Dec 6, 2023

Ok, let me check

vnbaaij added a commit that referenced this issue Dec 6, 2023
@vnbaaij vnbaaij mentioned this issue Dec 6, 2023
@vnbaaij
Copy link
Contributor

vnbaaij commented Dec 6, 2023

Fixed with PR #1249
aspire-navmenu

@v-cazhang
Copy link
Author

Verified on Aspire.ProjectTemplates.8.0.0-preview.3.23619.4, this issue has been fixed.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants