PR feedback

dotnet · Mar 25, 2024 · 0d5aa50 · 0d5aa50
1 parent 2fc8455
commit 0d5aa50
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Aspire.Dashboard/DashboardWebApplication.cs b/src/Aspire.Dashboard/DashboardWebApplication.cs
@@ -67,9 +67,10 @@ public DashboardWebApplication(Action<WebApplicationBuilder>? configureBuilder =
         builder.Logging.AddFilter("Microsoft.AspNetCore.Server.Kestrel", LogLevel.Error);
 #endif
 
+        // Allow for a user specified JSON config file on disk. Throw an error if the specified file doesn't exist.
         if (builder.Configuration[DashboardConfigNames.DashboardConfigFilePathName.ConfigKey] is { Length: > 0 } configFilePath)
         {
-            builder.Configuration.AddJsonFile(configFilePath, optional: true, reloadOnChange: true);
+            builder.Configuration.AddJsonFile(configFilePath, optional: false, reloadOnChange: true);
         }
 
         var dashboardConfigSection = builder.Configuration.GetSection("Dashboard");

diff --git a/tests/Aspire.Dashboard.Tests/Integration/StartupTests.cs b/tests/Aspire.Dashboard.Tests/Integration/StartupTests.cs
@@ -57,6 +57,24 @@ public async Task Configuration_NoExtraConfig_Error()
             s => s.Contains("Dashboard:Otlp:AuthMode"));
     }
 
+    [Fact]
+    public async Task Configuration_ConfigFilePathDoesntExist_Error()
+    {
+        // Arrange & Act
+        var configFilePath = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
+        var ex = await Assert.ThrowsAsync<FileNotFoundException>(async () =>
+        {
+            await using var app = IntegrationTestHelpers.CreateDashboardWebApplication(_testOutputHelper,
+                additionalConfiguration: data =>
+                {
+                    data[DashboardConfigNames.DashboardConfigFilePathName.ConfigKey] = configFilePath;
+                });
+        });
+
+        // Assert
+        Assert.Contains(configFilePath, ex.Message);
+    }
+
     [Fact]
     public async Task Configuration_OptionsMonitor_CanReadConfiguration()
     {