-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Move to latest SDK #9994
Conversation
Won't pass 'til release but ready |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@MattGal I'm not seeing actual failures in the Trx test log (no failures in the tests), but Helix is reporting exit code 1 for the run...any ideas? |
Yes there was an outage @adiaaida was commenting about in the AzDO API; if the work item finishes happily but the helix client fails to write test results to AzDO this happens. I think you can merge on red relatively safely here, or just re-run. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks like something real is really wrong. Last run failed about the same way as the first. |
We have opened an IcM with AzDO about this. Arcade issue is here: #10358 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I think something's genuinely broken about run 1933413, so I kicked off a new pipeline run to see what happens. We can escalate the IcM if needed but it's not broken universally (yet) |
It's almost nice that the problem reproduces so reliably 😦 We updated the SDK in
and didn't hit similar problems there. |
Arcade specifically does a bunch of custom types of test reporting, though the fact this isn't showing up in main-branch Arcade runs is very confusing (they use identical fake test results and the clients are versioned external-to-arcade). The Test API team work on IDC time so I'll start a thread to try to bump up priority of the IcM I opened. |
It's totally happening in main branch arcade. My one-pager is in arcade/main and I saw it there |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Just in case |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
We're all set but have two |
@AlitzelMendez will the .Net Helix Build Analysis go away? I'm fine checking this in. |
Build analysis changed the app they use. However, since this PR was opened before the swap, it left a dangling failed check using the old app. That dangling check didn't realize there were new runs. I clicked the rerun button which made the check update with the fact that the app was moved. |
Excellent e2e testing @riarenas 😁 |
The fact that older checks posted by the old app won't be updated is something we might want to make more widely known though @AlitzelMendez @missymessa |
That only worked because of the work that was deployed this week to make the re-run buttons do something for those checks, so it was a happy coincidence. |
To double check: