Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to PlatformAbstractions. #5410

Merged
merged 1 commit into from
May 6, 2020

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented May 4, 2020

This will allow us to remove the PlatformAbstractions library from dotnet/runtime.

Contributes to dotnet/runtime#3470

I couldn't find any callers of the GetTargetMachineInfo task. I'm not sure I looked everywhere, but since it is in the SharedFramework.Sdk package, it should only be used by runtime, aspnetcore, or windowsdesktop repos, right?

This will allow us to remove the PlatformAbstractions library from dotnet/runtime.

Contributes to dotnet/runtime#3470
@dagood
Copy link
Member

dagood commented May 5, 2020

[...] the SharedFramework.Sdk package, it should only be used by runtime, aspnetcore, or windowsdesktop repos, right?

Just runtime and windowsdesktop. aspnetcore, standard, and installer are other places that could potentially use it, but don't.

(Edit: Added more to the quote, but I do see how I'm kind of warping it and my comment was unclear.)

@ViktorHofer
Copy link
Member

ViktorHofer commented May 5, 2020

Runtime shouldn't use that task anymore so I assume just windowsdesktop?

@eerhardt
Copy link
Member Author

eerhardt commented May 5, 2020

Runtime shouldn't use that task anymore so I assume just windowsdesktop?

I believe @dagood was referring to this part:

but since it is in the SharedFramework.Sdk package

What I read is that only runtime and windowsdesktop repos use the SharedFramework.Sdk package.

@eerhardt eerhardt merged commit 31012ff into dotnet:master May 6, 2020
@eerhardt eerhardt deleted the RemovePlatformAbstractions branch May 6, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants