Add calleeType / conditionMemberNames to ActiveIssueAttribute #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the same type invoking mechanism that exists in ConditionalClass, Theroy, and Fact. Allows ActiveIssue to be a bit more exprssing when skipping.
akoeplinger
reviewed
Apr 29, 2020
src/Microsoft.DotNet.XUnitExtensions/src/Attributes/ActiveIssueAttribute.cs
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
Apr 29, 2020
akoeplinger
changed the title
|
@safern I just saw this, please take a look at the change. |
|
I'm not convinced if we should use |
|
I think it should fall in the same bucket as |
akoeplinger
added a commit
that referenced
this pull request
Jul 3, 2020
In #5376 the logic was copied from the ConditionalFactDiscoverer but this is wrong. For ActiveIssue we want to _skip_ the test if the condition is true, rather than the other way round.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the same type invoking mechanism that exists in ConditionalClass, Theory, and Fact. Allows ActiveIssue to be a bit more expressive when skipping: