Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for FreeBSD 11 & 12 rootfs #5100

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Mar 20, 2020

This is first step on path suggested by @jkotas so we can cross-compile FreeBSD on Linux.
With this (and few other changes) I can build FreeBSD images on my Ubuntu box

wfurt-runtime# uname -a
Linux 1879aec2a023 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
wfurt-runtime#sudo  eng/common/cross/build-rootfs.sh freebsd12   --rootfsdir /tmp/b12
wfurt-runtime# export CROSS_ROOTFS=/tmp/b12
wfurt-runtime# ./build.sh -cross -os FreeBSD
...
...
Build succeeded.
    0 Warning(s)
    0 Error(s)
Time Elapsed 00:13:26.46

I needed to to install few packages on Linux host

apt install  liblzma-dev  libz-dev libbz2-dev libarchive-dev  libbsd-dev

Since we do not do do that for other OSes I'll add note when building container.

freebsd11)
__FreeBSDBase="11.3-RELEASE"
;&
freebsd*)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we should name it freebsd12 instead, as the default __FreeBSDBase="12.1-RELEASE". As it is now it seems as if it supported any other freebsd version (someone might e.g. pass in freebsd10).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to have just "freebsd' and point that to 12 for now so not everybody need to track FreeBSD current version. But maybe that is rare and being explicit is better. For now, I only plan to create freebsd12 docker image and enable build only on 12 for runtime.

eng/common/cross/build-rootfs.sh Outdated Show resolved Hide resolved
eng/common/cross/build-rootfs.sh Outdated Show resolved Hide resolved
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants