Ibc merge failure logging #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
IBCMergeFailureLogging
branch
from
879136e to
577d5c6
Compare
tmat
force-pushed
the
IBCMergeFailureLogging
branch
from
577d5c6 to
86cee2b
Compare
chsienki
approved these changes
Jan 24, 2020
|
This likely broke the runtime repo: dotnet/runtime#2074 |
tmat
added a commit
to tmat/arcade
that referenced
this pull request
Apr 16, 2020
* Remove obsolete properties * Copy IbcMerge input files to log/ngen dir on failure
tmat
added a commit
that referenced
this pull request
Apr 17, 2020
* Ibc merge failure logging (#4678) * Remove obsolete properties * Copy IbcMerge input files to log/ngen dir on failure * Condition IBCMerge error handling on IBC run (#4714) Currently an IBCMerge error is thrown even though the tool doesn't even run. Adding a condition to only do error handling if IBC ran. As I already was there, I also conditioned the Message task. Co-authored-by: Viktor Hofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen some intermittent failures recently in our signed builds. Unfortunately, the build does not currently publish build artifacts when such failure occurs, so it's hard to investigate the cause. This change adds logic to copy the input files of IBCMerge to log directory if IbcMerge fails.