Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate shared framework manifest target, inverse xunit analyzer, reference Test SDK correctly #3139

Merged
merged 6 commits into from
Jun 29, 2019

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jun 23, 2019

Changes:

  • Add a generate shared framework manifest file target to handle conflict resolution.
  • PackageReference Microsoft.Net.Test.Sdk correctly
  • Simplify GenerateRuntimeConfigurationFiles and OverwriteTestRunnerConfigFile logic.
  • Exclude xunit.console.runtimeconfig.json from the nuget package to avoid races and duplicate file writes.
  • Remove GenerateRunScriptDependsOn as a sequenced extension point isn't needed for that target.
  • Remove runtimeconfig.dev.json copying as this file isn't needed anymore on netcoreapp3.0.
  • Change RemoveXUnitAnalyzer condition from an opt-in to an opt-out.

@ViktorHofer ViktorHofer requested review from ericstj and safern June 23, 2019 09:13
@ViktorHofer ViktorHofer self-assigned this Jun 23, 2019
@ViktorHofer ViktorHofer changed the title Inverse xunit analyzer, ref vstest correctly Add generate shared framework manifest target, inverse xunit analyzer, reference Test SDK correctly Jun 23, 2019
@ViktorHofer
Copy link
Member Author

@natemcmaster as you are composing your own shared framework in aspnetcore, you might be interested in commit nr 2 and discussion in dotnet/sdk#3335. If aspnetcore is hitting similar issues we might want to factor our the generate shared deps file task + this new task into its own package.

@natemcmaster
Copy link
Contributor

I'm on parental leave, so not currently working on anything. I would recommend talking with @dagood about shared framework work. Before I started leave, we started working on a way to commonize build tasks and targets for generating a shared framework. See #2704

@ViktorHofer ViktorHofer force-pushed the VSTestAnalzer branch 2 times, most recently from abc211b to 202dabd Compare June 24, 2019 15:32
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, make sure you have it passing and address feedback in the corefx staging PR before merging.

@ViktorHofer ViktorHofer merged commit d412d2b into dotnet:master Jun 29, 2019
@ViktorHofer ViktorHofer deleted the VSTestAnalzer branch June 29, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants