-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generate shared framework manifest target, inverse xunit analyzer, reference Test SDK correctly #3139
Conversation
@natemcmaster as you are composing your own shared framework in aspnetcore, you might be interested in commit nr 2 and discussion in dotnet/sdk#3335. If aspnetcore is hitting similar issues we might want to factor our the generate shared deps file task + this new task into its own package. |
3e5963f
to
4400017
Compare
4400017
to
b85ca03
Compare
abc211b
to
202dabd
Compare
src/Microsoft.DotNet.CoreFxTesting/build/Microsoft.DotNet.CoreFxTesting.targets
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, make sure you have it passing and address feedback in the corefx staging PR before merging.
2bbc653
to
e848ce4
Compare
e848ce4
to
5b1a1fc
Compare
Changes:
Microsoft.Net.Test.Sdk
correctlyGenerateRuntimeConfigurationFiles
andOverwriteTestRunnerConfigFile
logic.GenerateRunScriptDependsOn
as a sequenced extension point isn't needed for that target.RemoveXUnitAnalyzer
condition from an opt-in to an opt-out.