Update to .NET 10 SDK and TFM to net10.0 in arcade #15221
Conversation
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <IncludeDotNetCli Condition=" '$(IncludeDotNetCli)' != 'true' ">false</IncludeDotNetCli> | |||
| <AspNetCoreRuntimeVersion>9.0.0-rc.2.24474.3</AspNetCoreRuntimeVersion> | |||
| <AspNetCoreRuntimeVersion>10.0.0-alpha.2.24531.4</AspNetCoreRuntimeVersion> | |||
There was a problem hiding this comment.
I think it was unintentional that aspnetcore missed alpha 1. First net10.0 branding PR was merged dotnet/aspnetcore#57340 then few hours later on the same day, release/9.0 -> main sync bumped the prerelease dotnet/aspnetcore#57434 version.
cc @wtgodbe arcade has one failing test to keep the prerelease levels same, which is how this was detected. I think it's functionally not a problem, just a branding glitch.
There was a problem hiding this comment.
Thanks for catching that - opened dotnet/aspnetcore#58884
There was a problem hiding this comment.
Actually, would it be alright to disable the test for now? If we switch back to alpha1, anybody restoring with floating versions will get the last alpha2 package instead of the latest alpha1 package, until we switch to preview1
There was a problem hiding this comment.
I think it would be, or perhaps we can bump dotnet/sdk to alpha.2. @ViktorHofer's call. 🙂
There was a problem hiding this comment.
Spoke with Viktor offline about this, let's keep the branding as-is & disable the test for now
There was a problem hiding this comment.
We'll switch to preview.1 in not too long, so leaving as alpha.2 is fine by me.
|
@mmitche what do you think, should we start using a .NET 10 SDK in our repos? I would probably update to a slightly newer one before merging but it already includes the net10.0 TFM, templates and other changes that are needed. |
| @@ -16,6 +16,11 @@ | |||
| <RepositoryUrl>https://github.com/dotnet/arcade</RepositoryUrl> | |||
| <!-- Only upgrade NuGetAudit warnings to errors for official builds. --> | |||
| <WarningsNotAsErrors Condition="'$(OfficialBuild)' != 'true'">$(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors> | |||
| <!-- TODO: Remove when Arcade SDK updated TargetFrameworkDefaults.props for .NET 10. --> | |||
There was a problem hiding this comment.
| <!-- TODO: Remove when Arcade SDK updated TargetFrameworkDefaults.props for .NET 10. --> | |
| <!-- TODO: Remove when arcade updates to a new Arcade SDK with matching TargetFrameworkDefaults.props --> |
| @@ -1,10 +1,10 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "9.0.100", | |||
| "version": "10.0.100-alpha.1.24551.9", | |||
There was a problem hiding this comment.
Agreed, I would update to a newer SDK, but it probalby doesn't make too much difference.
To double check: