Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry search for upgrade policy keys #14975

Closed
wants to merge 2 commits into from

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Jul 24, 2024

Description

Add registry search operations to Windows installer bundles. The search operation will check for a global and version specific registry key. The version specific key takes precedence when present.

This is related to a customer request and part of a larger change. This PR only includes infrastructure changes to support changes in the Windows installer bundles.

Risk

Low, this change only adds detection for the key, nothing will currently act on its value.

Testing

Verified against a private build of Windows Desktop. Log excerpt below. The test machine contained both a global and version specific key.

HKEY_LOCAL_MACHINE\software\microsoft\.NET
    RemovePreviousVersion    REG_SZ    nextSession

HKEY_LOCAL_MACHINE\software\microsoft\.NET\6.0
    RemovePreviousVersion    REG_SZ    never
[0E70:11A0][2024-07-24T10:28:11]i000: Setting string variable 'WixBundleName' to value 'Microsoft Windows Desktop Runtime - 6.0.33 (x64)'
[0E70:0EBC][2024-07-24T10:28:11]i000: Setting version variable 'WixBundleFileVersion' to value '6.0.33.33924'
[0E70:11A0][2024-07-24T10:28:11]i000: Setting string variable 'RemoveUpgradeRelatedBundle' to value 'nextSession'
[0E70:11A0][2024-07-24T10:28:11]i000: Setting numeric variable 'RemoveSpecificPreviousVersionRegistryKeyExists' to value 1
[0E70:11A0][2024-07-24T10:28:11]i052: Condition 'RemoveSpecificPreviousVersionRegistryKeyExists=1' evaluates to true.
[0E70:11A0][2024-07-24T10:28:11]i000: Setting string variable 'RemoveUpgradeRelatedBundle' to value 'never'

@joeloff joeloff added the servicing-consider Servicing ask-mode label Jul 24, 2024
@rbhanda rbhanda added servicing-approved Approved for servicing and removed servicing-consider Servicing ask-mode labels Jul 30, 2024
@joeloff joeloff changed the base branch from release/6.0 to release/8.0 September 5, 2024 15:52
@joeloff joeloff changed the base branch from release/8.0 to release/6.0 September 5, 2024 15:53
@joeloff joeloff dismissed NikolaMilosavljevic’s stale review September 5, 2024 15:53

The base branch was changed.

@joeloff
Copy link
Member Author

joeloff commented Sep 5, 2024

/backport to release/8.0

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Started backporting to release/8.0: https://github.com/dotnet/arcade/actions/runs/10723898378

@joeloff
Copy link
Member Author

joeloff commented Sep 5, 2024

/backport to release/9.0

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Started backporting to release/9.0: https://github.com/dotnet/arcade/actions/runs/10723902401

@joeloff
Copy link
Member Author

joeloff commented Sep 5, 2024

/backport to main

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Started backporting to main: https://github.com/dotnet/arcade/actions/runs/10723921629

@joeloff
Copy link
Member Author

joeloff commented Sep 5, 2024

Closing since we will not be taking this for 6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
servicing-approved Approved for servicing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants