Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at prebuilt-detection #13027

Merged
merged 14 commits into from
Apr 7, 2023
Merged

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Apr 3, 2023

  • Add a few exclusions that will need SBRPs
  • Add dependencies on SBRP and SBE, with subscriptions
  • Added dependency on SDK and deployment tools. No subscription added for this.
  • Updated appinsights.

To double check:

- Add a few exclusions that will need SBRPs
- Add dependencies on SBRP and SBE, with subscriptions
- Added dependency on SDK and deployment tools. No subscription added for this.
@mmitche mmitche requested a review from a team April 3, 2023 22:57
@mmitche
Copy link
Member Author

mmitche commented Apr 3, 2023

@MichaelSimons Same process as with sdk. There are a few prebuilts left here in this PR. They're ancient, and I'd like to see whether they are upgradeable first.

@MichaelSimons
Copy link
Member

MichaelSimons commented Apr 4, 2023

FYI, @mthalman is adding the SBRPs in dotnet/source-build-reference-packages#595 least the ones he encountered when enabling the repo pvp feature.

@mmitche
Copy link
Member Author

mmitche commented Apr 4, 2023

@mthalman Hold off on System.IO.Packaging 4.5.0. I think that one may be upgradeable.

@mthalman
Copy link
Member

mthalman commented Apr 4, 2023

I'll be adding more packages to my PR that I missed: dotnet/source-build-reference-packages#595 (comment).

@mmitche - After applying your changes with my PVP flow changes, we're in alignment with the prebuilts that are showing up.

@mmitche
Copy link
Member Author

mmitche commented Apr 4, 2023

Thanks @MichaelSimons. I have eliminated a few more and am hunting down the last few where I think upgrades can be made.

@mmitche
Copy link
Member Author

mmitche commented Apr 4, 2023

@MichaelSimons I think this may be clean now.

@mmitche
Copy link
Member Author

mmitche commented Apr 4, 2023

@joeloff
Copy link
Member

joeloff commented Apr 4, 2023

@joeloff Any concern over the manfiest reader upgrade here? https://github.com/dotnet/arcade/pull/13027/files#diff-1ea18ff65faa2ae6fed570b83747086d0317f5e4bc325064f6c14319a9c4ff67R91

Should be fine. We only use that to process workload manifests from the Arcade build tasks in other repos (emsdk/runtime).

eng/Version.Details.xml Outdated Show resolved Hide resolved
eng/SourceBuildPrebuiltBaseline.xml Outdated Show resolved Hide resolved
@mmitche mmitche merged commit e3bfcab into dotnet:main Apr 7, 2023
@mmitche mmitche deleted the sb-prebuilt-detection branch April 7, 2023 15:30
@NikolaMilosavljevic
Copy link
Member

Fixes: #10721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants