[XABT] Add ArtifactFilename metadata for @(AndroidMavenLibrary) item.
#9479
+74
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
changed the title
ArtifactFilename metadata for AndroidMavenLibrary item.ArtifactFilename metadata for @(AndroidMavenLibrary) item.
jpobst
force-pushed
the
maven-override
branch
from
dda9800
to
6481997
Compare
jpobst
force-pushed
the
maven-override
branch
from
6481997
to
bbb48c5
Compare
jonathanpeppers
approved these changes
Nov 21, 2024
Comment on lines
+145
to
+146
| files_to_check.Add (Path.Combine (output_directory, $"{artifact.Id}-{artifact.Version}.jar")); | ||
| files_to_check.Add (Path.Combine (output_directory, $"{artifact.Id}-{artifact.Version}.aar")); |
There was a problem hiding this comment.
We don't have to do this here, but is there some manifest file that we can download to know the exact file name? It seems odd they can choose random names. How does Java tooling know which file to download?
There was a problem hiding this comment.
That is a good question. There doesn't appear to be anything in the .pom that gives the file name: https://repo1.maven.org/maven2/com/facebook/react/react-android/0.76.0/react-android-0.76.0.pom
It looks like React has its own Gradle plugin you need to use, perhaps it knows how to resolve their files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9465
In all of the examples we used when developing and testing
@(AndroidMavenLibrary)the Maven artifact filename followed the pattern{artifact.Id}-{artifact.Version}.[jar|aar], so this is the default filename we construct for the user.However, there exists some packages like React that do not follow this pattern and instead do eg:
react-android-0.76.0-release.aar. Attempting to use@(AndroidMavenLibrary)for React produces the following error:To support these cases, add a new optional metadata
ArtifactFilenamethat can be specified to override the Maven filename of the artifact.This allows our tasks to properly download the artifact and avoid the error.