Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Remove the last set of ignored MSBuild tests #8246

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

pjcollins
Copy link
Member

Fixes: #7777

The last set of ignored test categories have been removed or migrated to existing tests:

  • Test configurations related to AotMode=Hybrid and AotMode=Full have been removed.

  • BuildTest.CheckSequencePointGeneration has been removed due to it relying on mono symbol output.

  • EnvironmentContentTests.CheckBuildIdIsUnique has been removed due to it relying on mono symbol output.

  • PackagingTest.CheckManagedSymbolsArchive has been removed due to it relying on mono symbol output.

  • InstallAndRunTests.MonoSymbolicateAndroidStackTrace has been removed due to it relying on mono symbol output.

  • InstallAndRunTests.MonoSymbolicateNetStandardStackTrace has been removed due to it relying on mono symbol output.

  • EmbeddedDSOTests.BinariesExist removed as it is implicitly covered by tests that validate .apk contents.

  • EmbeddedDSOTests.EnvironmentFileContents removed as it is covered by BuildTest.CheckAssemblyCounts.

  • EmbeddedDSOTests.DSOPageAlignment assert moved to PackagingTest.EmbeddedDSOs.

  • EmbeddedDSOTests.DSOCompressionMode and EmbeddedDSOTests.AndroidManifestHasFlag removed as they are covered by PackagingTest.EmbeddedDSOs.

Fixes: dotnet#7777

The last set of ignored test categories have been removed or migrated to
existing tests:

  * Test configurations related to AotMode=Hybrid and AotMode=Full have been removed.

  * BuildTest.CheckSequencePointGeneration has been removed due to it relying on mono symbol output.

  * EnvironmentContentTests.CheckBuildIdIsUnique has been removed due to it relying on mono symbol output.

  * PackagingTest.CheckManagedSymbolsArchive has been removed due to it relying on mono symbol output.

  * InstallAndRunTests.MonoSymbolicateAndroidStackTrace has been removed due to it relying on mono symbol output.

  * InstallAndRunTests.MonoSymbolicateNetStandardStackTrace has been removed due to it relying on mono symbol output.

  * EmbeddedDSOTests.BinariesExist removed as it is implicitly covered by tests that validate .apk contents.

  * EmbeddedDSOTests.EnvironmentFileContents removed as it is covered by BuildTest.CheckAssemblyCounts.

  * EmbeddedDSOTests.DSOPageAlignment assert moved to PackagingTest.EmbeddedDSOs.

  * EmbeddedDSOTests.DSOCompressionMode and EmbeddedDSOTests.AndroidManifestHasFlag removed as they are covered by PackagingTest.EmbeddedDSOs.
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the test changes look good. 👍 Just had the one question.

I guess if mono-symbolicate ever came back, its replacement would probably look a lot different anyway. I don't think we'd even be able to use those tests.

@pjcollins pjcollins merged commit a427688 into dotnet:main Aug 9, 2023
@pjcollins pjcollins deleted the ignored-cats branch August 9, 2023 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests] Audit tests annotated with DotNetIgnore or other ignored categories
3 participants