[tests] Move Mono.Android-Tests to top tests dir #5281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#5250 PR dotnet#5250 will be adding another another Mono.Android-Tests project file, and it feels like a good time to move all relevant Mono.Android test source into a single location and reduce duplication where possible. The `src/Mono.Android/Test/` folder has been moved into the top level `tests` directory. The two existing `tests/Runtime-*` folders have been moved under the new `tests/Mono.Android-Tests` folder. Some duplication that existed in the .targets and .projitems files that belonged to these test projects has been cleaned up. The obsolete `TestInstrumentation` class has been deleted in favor of the newer `NUnitInstrumentation` class. The `Build.GetSerial ()` API is restricted on API 29+, so a check has been added to prevent the following exception: AndroidRuntime: FATAL EXCEPTION: Instr: xamarin.android.runtimetests.NUnitInstrumentation AndroidRuntime: Process: Mono.Android_Tests, PID: 3489 AndroidRuntime: java.lang.SecurityException: getSerial: The user 10106 does not meet the requirements to access device identifiers. AndroidRuntime: at android.os.Parcel.createException(Parcel.java:2071) AndroidRuntime: at android.os.Parcel.readException(Parcel.java:2039) AndroidRuntime: at android.os.Parcel.readException(Parcel.java:1987) AndroidRuntime: at android.os.IDeviceIdentifiersPolicyService$Stub$Proxy.getSerialForPackage(IDeviceIdentifiersPolicyService.java:159) AndroidRuntime: at android.os.Build.getSerial(Build.java:162)
tests/Mono.Android-Tests/Runtime-AppBundle/Mono.Android-TestsAppBundle.csproj
Outdated
Show resolved
Hide resolved
jonathanpeppers
approved these changes
Nov 10, 2020
radekdoulik
approved these changes
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #5250
PR #5250 will be adding another another Mono.Android-Tests project file,
and it feels like a good time to move all relevant Mono.Android test
source into a single location and reduce duplication where possible.
The
src/Mono.Android/Test/folder has been moved into the top leveltestsdirectory. The two existingtests/Runtime-*folders have beenmoved under the new
tests/Mono.Android-Testsfolder. Some duplicationthat existed in the .targets and .projitems files that belonged to these
test projects has been cleaned up.
The obsolete
TestInstrumentationclass has been deleted in favor ofthe newer
NUnitInstrumentationclass.The
Build.GetSerial ()API is restricted on API 29+, so a check hasbeen added to prevent the following exception: