NuGet v5.1.7, disable Nagle by default, thank you @sancheolz

dotnet · Aug 25, 2023 · d433347 · d433347
1 parent ec984fa
commit d433347
Show file tree

Hide file tree

Showing 26 changed files with 31 additions and 28 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ v5.1.x
 
 - Strong name signing
 - Better exception logging
+- Set ```Settings.NoDelay``` to ```true``` by default (disabling Nagle's algorithm)
 
 ## Previous Versions
 

diff --git a/README.md b/README.md
@@ -19,14 +19,15 @@ Special thanks to the following people for their support and contributions to th
 @NormenSchwettmann @karstennilsen @motridox @AdamFrisby @Job79 @Dijkstra-ru @playingoDEERUX
 @DuAell @syntacs @zsolt777 @broms95 @Antwns @MartyIX @Jyck @Memphizzz @nirajgenius 
 @cee-sharp @jeverz @cbarraco @DenisBalan @Markonius @Ahmed310 @markashleybell @thechosensausage
-@JVemon @eatyouroats @bendablegears @Laiteux @fisherman6v6 @wesoos @YorVeX @tovich37
+@JVemon @eatyouroats @bendablegears @Laiteux @fisherman6v6 @wesoos @YorVeX @tovich37 @sancheolz
 
 If you'd like to contribute, please jump right into the source code and create a pull request, or, file an issue with your enhancement request. 
 
 ## New in v5.1.x
 
 - Strong name signing
 - Better exception logging
+- Set ```Settings.NoDelay``` to ```true``` by default (disabling Nagle's algorithm)
 
 ## Test Applications
 

diff --git a/src/Test.Client/Test.Client.csproj b/src/Test.Client/Test.Client.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.ClientStream/Test.ClientStream.csproj b/src/Test.ClientStream/Test.ClientStream.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.Deadlock/Test.Deadlock.csproj b/src/Test.Deadlock/Test.Deadlock.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.FastDisconnect/Test.FastDisconnect.csproj b/src/Test.FastDisconnect/Test.FastDisconnect.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.FileTransfer/Test.FileTransfer.csproj b/src/Test.FileTransfer/Test.FileTransfer.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.LargeMessages/Test.LargeMessages.csproj b/src/Test.LargeMessages/Test.LargeMessages.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.MaxConnections/Test.MaxConnections.csproj b/src/Test.MaxConnections/Test.MaxConnections.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-	  <TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+	  <TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Test.Metadata/Test.Metadata.csproj b/src/Test.Metadata/Test.Metadata.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.MultiClient/Test.MultiClient.csproj b/src/Test.MultiClient/Test.MultiClient.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.MultiThread/Test.MultiThread.csproj b/src/Test.MultiThread/Test.MultiThread.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.NonExistentServer/Test.NonExistentServer.csproj b/src/Test.NonExistentServer/Test.NonExistentServer.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.Parallel/Test.Parallel.csproj b/src/Test.Parallel/Test.Parallel.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.PartialStream/Test.PartialStream.csproj b/src/Test.PartialStream/Test.PartialStream.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.Reconnect/Test.Reconnect.csproj b/src/Test.Reconnect/Test.Reconnect.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.Server/Test.Server.csproj b/src/Test.Server/Test.Server.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.ServerStream/Test.ServerStream.csproj b/src/Test.ServerStream/Test.ServerStream.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.SyncMessages/Test.SyncMessages.csproj b/src/Test.SyncMessages/Test.SyncMessages.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.Throughput/Test.Throughput.csproj b/src/Test.Throughput/Test.Throughput.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.TimeoutRecovery/Test.TimeoutRecovery.csproj b/src/Test.TimeoutRecovery/Test.TimeoutRecovery.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/src/Test.WinFormServer/Program.cs b/src/Test.WinFormServer/Program.cs
@@ -3,6 +3,7 @@
 using System.Linq;
 using System.Threading.Tasks;
 using System.Windows.Forms;
+using WatsonTcp;
 
 namespace Test.WinFormServer
 {

diff --git a/src/WatsonTcp/WatsonTcp.csproj b/src/WatsonTcp/WatsonTcp.csproj
@@ -1,10 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
-		<TargetFrameworks>netstandard2.0;netstandard2.1;netcoreapp3.1;net461;net462;net48;net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>netstandard2.0;netstandard2.1;netcoreapp3.1;net461;net462;net48;net6.0;net7.0;net8.0</TargetFrameworks>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
 		<GenerateDocumentationFile>true</GenerateDocumentationFile>
-		<Version>5.1.6</Version>
+		<Version>5.1.7</Version>
 		<Authors>Joel Christner</Authors>
 		<Company>Joel Christner</Company>
 		<Description>A simple C# async TCP server and client with integrated framing for reliable transmission and receipt of data</Description>

diff --git a/src/WatsonTcp/WatsonTcp.xml b/src/WatsonTcp/WatsonTcp.xml
diff --git a/src/WatsonTcp/WatsonTcpClientSettings.cs b/src/WatsonTcp/WatsonTcpClientSettings.cs
@@ -158,9 +158,9 @@ public int LocalPort
         }
 
         /// <summary>
-        /// Disable the delay when send or receive buffers are not full.  If true, disable the delay.  Default is false.
+        /// Nagle's algorithm.  Disable the delay when send or receive buffers are not full.  If true, disable the delay.  Default is true.
         /// </summary>
-        public bool NoDelay { get; set; } = false;
+        public bool NoDelay { get; set; } = true;
 
         #endregion
 

diff --git a/src/WatsonTcp/WatsonTcpServerSettings.cs b/src/WatsonTcp/WatsonTcpServerSettings.cs
@@ -146,9 +146,9 @@ public List<string> BlockedIPs
         }
 
         /// <summary>
-        /// Disable the delay when send or receive buffers are not full.  If true, disable the delay.  Default is false.
+        /// Nagle's algorithm.  Disable the delay when send or receive buffers are not full.  If true, disable the delay.  Default is true.
         /// </summary>
-        public bool NoDelay { get; set; } = false;
+        public bool NoDelay { get; set; } = true;
 
         #endregion