Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize versions/packages across nuspec and ref project, Add .NET9 #3045

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 27, 2024

Copilot Summary

This pull request includes several updates to the Microsoft.Data.SqlClient package to add support for .NET 9.0 and update dependencies. The most important changes include adding new package references, updating existing dependencies, and adding support for .NET 9.0 in the nuspec file.

Dependency Updates:

  • Added System.Security.Cryptography.Pkcs and Microsoft.Bcl.Cryptography package references in netcore and netfx project files. [1] [2]

Nuspec File Updates:

  • Updated Microsoft.Extensions.Caching.Memory to version 9.0.0 and other dependencies to version 9.0.0 for .NET 8.0 and .NET 9.0.
  • Added support for .NET 9.0, including dependency and reference groups. [1] [2] [3] [4]

Human description

This synchronizes versions to the nuspec file, it also adds missing packages and adds.NET9support
Also, 2 libraries were missing from the ref projects

I'm not sure if this is all needed or not, but I think it is?

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.80%. Comparing base (b9877f4) to head (f9d6689).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3045       +/-   ##
===========================================
- Coverage   92.58%   72.80%   -19.78%     
===========================================
  Files           6      285      +279     
  Lines         310    59171    +58861     
===========================================
+ Hits          287    43079    +42792     
- Misses         23    16092    +16069     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.53% <ø> (?)
netfx 71.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edwardneal
Copy link
Contributor

Thanks for this. The ref project references determine how Visual Studio generates its assembly redirects in .NET Framework applications, but these dropped a little out of sync during the update.

@mdaigle
Copy link
Contributor

mdaigle commented Nov 27, 2024

Thanks!

@mdaigle mdaigle merged commit f8c5f76 into dotnet:main Nov 27, 2024
252 checks passed
mdaigle pushed a commit to mdaigle/SqlClient that referenced this pull request Nov 27, 2024
mdaigle added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants