Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Blurp
This pull request includes changes to improve the reliability of connection tests by adjusting connection timeouts. The most important changes include setting a minimum connection timeout in the
ConversionTests
andEventCounterTest
classes.Improvements to connection tests:
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ConversionTests.cs
: Adjusted the connection timeout to a minimum of 30 seconds in thepublic ConversionTests()
method to reduce the likelihood of connection timeouts during tests.src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/EventCounterTest.cs
: Added a minimum connection timeout of 30 seconds in thepublic void EventCounter_ReclaimedConnectionsCounter_Functional()
method to ensure consistent test execution.Description
There are quite a few test failures on these methods:
https://sqlclientdrivers.visualstudio.com/public/_test/analytics?definitionId=1879&contextType=build
Many of the failures are timeouts, so I'm trying to see if increasing the timeout a bit could help make these tests more stable