Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timeout of tests #3026

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Nov 20, 2024

AI Blurp

This pull request includes changes to improve the reliability of connection tests by adjusting connection timeouts. The most important changes include setting a minimum connection timeout in the ConversionTests and EventCounterTest classes.

Improvements to connection tests:

Description

There are quite a few test failures on these methods:
https://sqlclientdrivers.visualstudio.com/public/_test/analytics?definitionId=1879&contextType=build

Many of the failures are timeouts, so I'm trying to see if increasing the timeout a bit could help make these tests more stable

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.71%. Comparing base (b1f7eaf) to head (a063ec4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3026      +/-   ##
==========================================
+ Coverage   72.68%   72.71%   +0.02%     
==========================================
  Files         285      285              
  Lines       59155    59160       +5     
==========================================
+ Hits        42998    43017      +19     
+ Misses      16157    16143      -14     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.44% <ø> (+0.05%) ⬆️
netfx 71.13% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cheenamalhotra cheenamalhotra added this to the 6.0-preview3 milestone Nov 20, 2024
@cheenamalhotra cheenamalhotra added the Area\Tests Issues that are targeted to tests or test projects label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants