-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge | SNI Wrapper Class Extraction #3002
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NINativeMethodWrapper.Common.cs
benrr101
added
the
Common Project 🚮
Things that relate to the common project project
label
Nov 13, 2024
benrr101
requested review from
saurabh500,
mdaigle,
cheenamalhotra,
David-Engel and
samsharma2700
November 13, 2024 19:00
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
==========================================
+ Coverage 72.44% 72.69% +0.24%
==========================================
Files 288 285 -3
Lines 59493 59155 -338
==========================================
- Hits 43102 43003 -99
+ Misses 16391 16152 -239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheenamalhotra
approved these changes
Nov 14, 2024
samsharma2700
approved these changes
Nov 14, 2024
David-Engel
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Finally we're moving onto merging the SNI wrapper class. The strategy for merging this class is to
This PR reduces the bulk of the code in the netcore SNINativeMethodWrapper class, making merging much easier.
Testing: This is another PR where code is just moving around, not changing functionality. As such, the pipeline build should verify it.