Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge | SNI Wrapper Class Extraction #3002

Merged
merged 10 commits into from
Nov 16, 2024

Conversation

benrr101
Copy link
Contributor

Description: Finally we're moving onto merging the SNI wrapper class. The strategy for merging this class is to

  1. Extract classes/enums from the main class into separate files. (this PR)
  2. Create an interface for native method providers and switch which implementation is used based on platform (next PR, ready to go)
  3. Merge remaining code (PR after that)

This PR reduces the bulk of the code in the netcore SNINativeMethodWrapper class, making merging much easier.

Testing: This is another PR where code is just moving around, not changing functionality. As such, the pipeline build should verify it.

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Nov 13, 2024
@benrr101 benrr101 added this to the 6.0-preview3 milestone Nov 13, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 87.27273% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (a6f9ce3) to head (5d6ee99).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
....SqlClient/src/Microsoft/Data/SqlClient/SqlUtil.cs 0.00% 3 Missing ⚠️
...src/Microsoft/Data/SqlClient/LocalDBAPI.Windows.cs 0.00% 2 Missing ⚠️
...t/netfx/src/Microsoft/Data/SqlClient/LocalDBAPI.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
+ Coverage   72.44%   72.69%   +0.24%     
==========================================
  Files         288      285       -3     
  Lines       59493    59155     -338     
==========================================
- Hits        43102    43003      -99     
+ Misses      16391    16152     -239     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.45% <81.25%> (+0.07%) ⬆️
netfx 71.09% <84.37%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101 benrr101 merged commit b1f7eaf into dotnet:main Nov 16, 2024
82 checks passed
@benrr101 benrr101 deleted the merge/sniwrapper-extraction branch November 16, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants