Upgrade / align packages in test projects /

[MichelZ]

• Upgrade packages that are used in NETCORE only to 8+
• Upgrade packages only used in test projects to latest versions
• Upgrade XUnit / MSTest SDK
• Remove unused variables
  • MicrosoftNETCoreRuntimeCoreCLRVersion
  • MicrosoftDotNetPlatformAbstractionsVersion
  • SystemTextEncodingCodePagesVersion
• Remove reference to xunit.runner.utility, this should not be linked as per xunit.runner.visualstudio 2.8.1 fails to discover .Net 4.7.2 Unit Tests xunit/visualstudio.xunit#409 (comment)

According to #2379 (comment), the Remote Executor package and XUnit was held back by .NET6, now that .NET6 is removed, this should work fine

[ErikEJ]

Looks like you missed some project file updates?

[MichelZ]

Looks like you missed some project file updates?

Looks like the issue with the build is that the packages are not available in the officially cached version of the sqlclientdrivers feed. I've built the project locally (with nuget.org as source) and it worked fine

[benrr101]

@MichelZ Ah, yeah, I recently learned this as well. We only allow contributors to add new package versions to our internal nuget feed. I was also shown how to manually add them, so give me a bit and I'll get them added so we can kick off the build in earnest.

[benrr101]

Upstream packages have been added to the feed, let's see what azp thinks

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[MichelZ]

@benrr101 Can you cache these additional, transitive packages:
xunit.analyzers.1.16.0
xunit.runner.utility.2.9.2
xunit.runner.console.2.9.2
xunit.core.2.9.2
xunit.assert.2.9.2
xunit.extensibility.core.2.9.2
xunit.extensibility.execution.2.9.2
Microsoft.TestPlatform.ObjectModel 17.11.1
Microsoft.TestPlatform.TestHost 17.11.1
Microsoft.CodeCoverage 17.11.1

Thaaaanks :)

[benrr101]

All updated - let's give it another run

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[MichelZ]

It seems that net462 tests are not discovered anymore. Will look into that

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.85%. Comparing base (1348c3c) to head (1ae7a52).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2980      +/-   ##
==========================================
- Coverage   72.67%   66.85%   -5.82%     
==========================================
  Files         285      285              
  Lines       59160    64582    +5422     
==========================================
+ Hits        42997    43179     +182     
- Misses      16163    21403    +5240     

Flag	Coverage Δ
addons	92.58% <ø> (ø)
netcore	72.52% <ø> (-2.92%)	⬇️
netfx	64.49% <ø> (-6.58%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[MichelZ]

net462 tests running again

[MichelZ]

While we're at it, I guess it makes sense to upgrade the arcade packages as well, can you cache:
Microsoft.DotNet.RemoteExecutor - 10.0.0-beta.24564.1
Microsoft.DotNet.XUnitExtensions - 10.0.0-beta.24564.1

[MichelZ]

I've also seen that we sometimes seem to hit this XUnit bug that would get resolved as well with this PR and make tests more stable

[David-Engel]

While we're at it, I guess it makes sense to upgrade the arcade packages as well, can you cache: Microsoft.DotNet.RemoteExecutor - 10.0.0-beta.24564.1 Microsoft.DotNet.XUnitExtensions - 10.0.0-beta.24564.1

Done!

[MichelZ]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 2980 in repo dotnet/SqlClient

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[cheenamalhotra]

Package updates are coming in #2946 and then this PR could adjust changes needed, if any.

[MichelZ]

Absolutely, will do