Merge | Align BitConverter/BinaryPrimitives usage netfx/netcore

[MichelZ]

This uses System.Buffers.Binary types instead of BitConverter to align netfx with netcore

Part of #2953

[benrr101]

It's worth explicitly calling out that the the behavior of BitConverter and BinaryPrimitives is not the same (BinaryPrimitives require specifying the endianness while BitConverter uses the system's endianness). For netcore, it makes sense to specify little-endian conversion since netcore can be expected to run on big-endian systems. For netfx, it made sense to use the system endianness since it wasn't expected that netfx would run on big-endian systems (though I'm not sure how accurate that expectation is). Thus, bringing the netcore implementation to the netfx codebase should be safe.

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[MichelZ]

Grrr AZD

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.44%. Comparing base (9d5ca32) to head (a2a39e4).
Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2963      +/-   ##
==========================================
+ Coverage   72.31%   72.44%   +0.12%     
==========================================
  Files         288      288              
  Lines       59660    59529     -131     
==========================================
- Hits        43145    43125      -20     
+ Misses      16515    16404     -111     

Flag	Coverage Δ
addons	92.58% <ø> (ø)
netcore	75.36% <ø> (-0.07%)	⬇️
netfx	70.92% <33.33%> (+0.23%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MichelZ]

Anything I can do to move this along?

[mdaigle]

It's worth explicitly calling out that the the behavior of BitConverter and BinaryPrimitives is not the same (BinaryPrimitives require specifying the endianness while BitConverter uses the system's endianness). For netcore, it makes sense to specify little-endian conversion since netcore can be expected to run on big-endian systems. For netfx, it made sense to use the system endianness since it wasn't expected that netfx would run on big-endian systems (though I'm not sure how accurate that expectation is). Thus, bringing the netcore implementation to the netfx codebase should be safe.

In fact, all integer values in TDS should be represented in little endian unless it's specifically mentioned that they should be big endian. The only fields with special treatment are:

• VERSION in PL_OPTION_TOKEN
• PL_OFFSET and PL_OPTION_LENGTH in PRELOGIN
• SPID and Length in the packet header

It looks like we only touch the fed auth options packet and row level data field parsing in this PR, so little endian should be correct.