Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress roslyn errors and warnings #2936

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Oct 29, 2024

Suppresses roslyn errors/warnings captured in CI:

##[warning]3. RoslynAnalyzers Warning CA5398 - File: file:///C:/__w/1/s/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs. Line: 770. Column 52. 
Tool: RoslynAnalyzers: Rule: CA5398 (Avoid hardcoded SslProtocols values). https://docs.microsoft.com/visualstudio/code-quality/ca5398
Avoid hardcoding SslProtocols 'Tls12' to ensure your application remains secure in the future. Use 'None' to let the Operating System choose a version.

##[error]4. RoslynAnalyzers Error CA5397 - File: file:///C:/__w/1/s/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs. Line: 822. Column 89. 
Tool: RoslynAnalyzers: Rule: CA5397 (Do not use deprecated SslProtocols values). https://docs.microsoft.com/visualstudio/code-quality/ca5397
Transport Layer Security protocol version 'Tls11' is deprecated.  Use 'None' to let the Operating System choose a version.

##[warning]5. RoslynAnalyzers Warning CA5398 - File: file:///C:/__w/1/s/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs. Line: 416. Column 40. 
Tool: RoslynAnalyzers: Rule: CA5398 (Avoid hardcoded SslProtocols values). https://docs.microsoft.com/visualstudio/code-quality/ca5398
Avoid hardcoding SslProtocols 'Tls13' to ensure your application remains secure in the future. Use 'None' to let the Operating System choose a version.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.25%. Comparing base (39c4604) to head (ece8cb8).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2936      +/-   ##
==========================================
+ Coverage   71.92%   72.25%   +0.33%     
==========================================
  Files         294      291       -3     
  Lines       60342    59769     -573     
==========================================
- Hits        43398    43185     -213     
+ Misses      16944    16584     -360     
Flag Coverage Δ
addons 92.90% <ø> (ø)
netcore 75.83% <ø> (+<0.01%) ⬆️
netfx 70.59% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheenamalhotra cheenamalhotra merged commit 699f6ab into dotnet:main Oct 29, 2024
124 checks passed
@cheenamalhotra cheenamalhotra deleted the fix-roslyn-error branch October 29, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants