Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Suppress CodeQL X509RevocationMode warning. #2432

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Fix | Suppress CodeQL X509RevocationMode warning. #2432

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4de73c
Suppress CodeQL X509RevocationMode warning.
arellegue Mar 26, 2024
7ec2afe
Removed mention of legacy code.
arellegue Mar 26, 2024
34e4a25
Add comment as suggested by AE team.
arellegue Mar 28, 2024
aa03d41
Update src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Virt…
David-Engel Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...osoft.Data.SqlClient/src/Microsoft/Data/SqlClient/VirtualSecureModeEnclaveProviderBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ private bool VerifyHealthReportAgainstRootCertificate(X509Certificate2Collection
chain.ChainPolicy.ExtraStore.Add(cert);
}

// Per AE Team - "An Always Encrypted-enabled driver doesn't verify an expiration date or a certificate authority chain.
// A certificate is simply used as a key pair consisting of a public and private key. Please go with no-check option and
// do add the comment in the code so that in future next dev knows why we decided to do it."

// CodeQL [SM00395] False Positive: Suppressing CodeQL warning
David-Engel marked this conversation as resolved.
Show resolved Hide resolved
chain.ChainPolicy.RevocationMode = X509RevocationMode.NoCheck;

if (!chain.Build(healthReportCert))
Expand Down
Loading