Code Merge | TdsParserStateObject alignment #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Engel
commented
Jun 28, 2023
| AddError(_parser.ProcessSNIError(this)); | ||
| ThrowExceptionAndWarning(callerHasConnectionLock, false); | ||
| ThrowExceptionAndWarning(callerHasConnectionLock, asyncClose); |
There was a problem hiding this comment.
I think this was a bug introduced in 1766.
Wraith2
reviewed
Jun 28, 2023
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Outdated
Show resolved
Hide resolved
Wraith2
reviewed
Jun 28, 2023
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
+ Coverage 69.89% 70.61% +0.71%
==========================================
Files 305 305
Lines 61944 61950 +6
==========================================
+ Hits 43297 43743 +446
+ Misses 18647 18207 -440
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
David-Engel
requested review from
JRahnama,
DavoudEshtehari,
Kaur-Parminder and
arellegue
Kaur-Parminder
approved these changes
Jul 5, 2023
DavoudEshtehari
added
the
➕ Code Health
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making TdsParserStateObject.cs look closer between netcore and netfx prior to actual merge.
This was done by going through a diff between netfx and netcore TdsParserStateObject.cs and merging the easy items like code formatting, typos, white space, trace messages, simple variable refactor.
This diff should be easy to digest for PR reviewers. 5-10 minutes.