Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | SqlDataSourceEnumeratorTest correct ConditionalFact #2058

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

David-Engel
Copy link
Contributor

Skip test if SQLBrowser is missing or not running.

Skip test if SQLBrowser is missing or not running.
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (244a340) 69.86% compared to head (ca98ca8) 69.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
- Coverage   69.86%   69.86%   -0.01%     
==========================================
  Files         305      305              
  Lines       61819    61819              
==========================================
- Hits        43191    43187       -4     
- Misses      18628    18632       +4     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.36% <ø> (+0.02%) ⬆️
netfx 68.09% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavoudEshtehari DavoudEshtehari added the Area\Tests Issues that are targeted to tests or test projects label Jun 12, 2023
@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview3 milestone Jun 12, 2023
@JRahnama JRahnama merged commit 2b31810 into dotnet:main Jun 12, 2023
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
Skip test if SQLBrowser is missing or not running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants