Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test | Replacing try/catch with xUnit Throws. #2054

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Test | Replacing try/catch with xUnit Throws. #2054

merged 1 commit into from
Jun 8, 2023

Conversation

JRahnama
Copy link
Contributor

@JRahnama JRahnama commented Jun 7, 2023

try/catch in BasicConnectionTests made the pipelines unhappy. Replacing them solves the issue. No Exception is thrown, but
image

@JRahnama JRahnama added this to the 5.2.0-preview2 milestone Jun 7, 2023
@JRahnama JRahnama added the Area\Tests Issues that are targeted to tests or test projects label Jun 7, 2023
Copy link
Contributor

@arellegue arellegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@DavoudEshtehari DavoudEshtehari merged commit e3787ff into dotnet:main Jun 8, 2023
kant2002 pushed a commit to kant2002/SqlClient that referenced this pull request Jun 29, 2023
@JRahnama JRahnama deleted the updating-xunit-throws-in-test branch September 8, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants