[5.0.2] Fix | Release connection lock before signaling SinglePhaseCommit completion #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcheunglci
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 5.0-servicing #1975 +/- ##
=================================================
- Coverage 71.63% 71.41% -0.22%
=================================================
Files 293 293
Lines 61377 61377
=================================================
- Hits 43965 43832 -133
- Misses 17412 17545 +133
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
DavoudEshtehari
approved these changes
Mar 30, 2023
JRahnama
approved these changes
Mar 30, 2023
lcheunglci
deleted the
5.0-Backport-1801-Fix-Deadlock-on-SinglePhaseCommit-Distributed-Tx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fix to 5.0-servicing branch. This fixes the deadlock issue for SinglePhaseCommit with Distributed Transaction. These changes are based on #1801