Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1.1] Fix | TransactionScope connection issue when Enlist is enable, Pooling is disable and network connection type is Redirect #1967

Conversation

lcheunglci
Copy link
Contributor

Backporting fix to TransactionScope connection failure when the network connection type is set to Redirect and connection pooling is disabled and it tries to enlist on 5.1-servicing branch. These changes are based on #1960

…g is disabled and network connection type is Redirect (dotnet#1960)
@lcheunglci lcheunglci added this to the 5.1.1 milestone Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (0156df2) 70.83% compared to head (bcf9ee9) 70.77%.

Additional details and impacted files
@@                Coverage Diff                @@
##           5.1-servicing    #1967      +/-   ##
=================================================
- Coverage          70.83%   70.77%   -0.06%     
=================================================
  Files                292      292              
  Lines              61732    61732              
=================================================
- Hits               43730    43693      -37     
- Misses             18002    18039      +37     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.23% <100.00%> (-0.08%) ⬇️
netfx 69.28% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 73.64% <100.00%> (-0.50%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 68.06% <100.00%> (ø)

... and 32 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lcheunglci lcheunglci merged commit daa1a74 into dotnet:5.1-servicing Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants