-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft | Addressing the issue with wrong exception when column decryption fails. #1897
Conversation
Codecov ReportBase: 70.70% // Head: 69.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1897 +/- ##
==========================================
- Coverage 70.70% 69.91% -0.80%
==========================================
Files 292 292
Lines 61732 61733 +1
==========================================
- Hits 43647 43159 -488
- Misses 18085 18574 +489
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
{ | ||
if (token == TdsEnums.SQLERROR) | ||
if (token == TdsEnums.SQLERROR || token == TdsEnums.SQLDEBUG_CMD) // This the value of 0x60 send fromm TDS Control token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what the comment is trying to communicate here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the comment since this was a draft PR and I needed to make a change to run the pipelines I did not pay much attention to it.
The specs do not provide any info on that TDS token stream. At first, I did not notice that 0x60 is available in TDSEnums. basically, the issue was raised by PS team. They tried to provide an invalid token(AE token not TDS header token) to decrypt an encrypted column. Server returns 96 instead of error token (0xaa).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're getting it from the server then either they need to update the spec or stop sending it. I think updating the spec is easier.
@@ -149,7 +149,7 @@ internal static class TdsEnums | |||
public const byte SQLDONEINPROC = 0xff; | |||
public const byte SQLOFFSET = 0x78; | |||
public const byte SQLORDER = 0xa9; | |||
public const byte SQLDEBUG_CMD = 0x60; | |||
public const byte SQLDEBUG_CMD = 0x60; // This needs more info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who needs to provide the info? the SQL Server team? The spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to provide more info and add it here 😄 . This is just a replacement for more info and triggering pipelines.
Should we close this PR since the fix in #1948 address this issue as well? |
I forgot. I should close this. |
No description provided.