Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SNI Version to 5.1.0 #1889

Merged
merged 18 commits into from
Jan 16, 2023
Merged

Conversation

Kaur-Parminder
Copy link
Contributor

@Kaur-Parminder Kaur-Parminder commented Jan 13, 2023

SNI 5.1.0 Release:

  • Update to VS2022
  • Upgrade net 46 to net462

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Base: 70.63% // Head: 70.22% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (ff1d006) compared to base (af0a376).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
- Coverage   70.63%   70.22%   -0.41%     
==========================================
  Files         292      292              
  Lines       61732    61732              
==========================================
- Hits        43603    43353     -250     
- Misses      18129    18379     +250     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.40% <ø> (-0.64%) ⬇️
netfx 69.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 23.30% <0.00%> (-20.90%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 73.77% <0.00%> (-4.92%) ⬇️
...c/Microsoft/Data/Interop/SNINativeMethodWrapper.cs 75.43% <0.00%> (-1.01%) ⬇️
...osoft/Data/SqlClient/TdsParserStateObjectNative.cs 86.84% <0.00%> (-0.53%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 66.46% <0.00%> (-0.35%) ⬇️
...SqlClient/src/Microsoft/Data/SqlClient/TdsEnums.cs 95.91% <0.00%> (-0.35%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 20.45% <0.00%> (+3.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavoudEshtehari DavoudEshtehari added this to the 5.1.0 milestone Jan 16, 2023
@DavoudEshtehari DavoudEshtehari added the Area\Native SNI Issues that are targeted to the Native SNI codebase. label Jan 16, 2023
@DavoudEshtehari DavoudEshtehari merged commit 35a029f into dotnet:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Native SNI Issues that are targeted to the Native SNI codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants