Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test | Fix akvtest issues #1842

Merged
merged 11 commits into from
Nov 21, 2022
Merged

Test | Fix akvtest issues #1842

merged 11 commits into from
Nov 21, 2022

Conversation

JRahnama
Copy link
Contributor

@JRahnama JRahnama commented Nov 17, 2022

I noticed the AKVTests (3 tests in total) are skipped and have never run on our AE tests due to nameof(DataTestUtility.AreConnStringsSetup) in tests condition.

There will be one failure due to an exception change in Azure.Identity 1.7.0 since the expected error message has been changed. Read here.

@JRahnama JRahnama changed the title Fix akvtestissues Test | Fix akvtest issues Nov 17, 2022
@JRahnama JRahnama closed this Nov 17, 2022
@JRahnama JRahnama reopened this Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 70.20% // Head: 69.23% // Decreases project coverage by -0.96% ⚠️

Coverage data is based on head (e4d9b1b) compared to base (c765d83).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   70.20%   69.23%   -0.97%     
==========================================
  Files         292      292              
  Lines       61727    61727              
==========================================
- Hits        43333    42739     -594     
- Misses      18394    18988     +594     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.33% <ø> (-0.78%) ⬇️
netfx 67.61% <ø> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 26.18% <0.00%> (-23.00%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 23.30% <0.00%> (-22.77%) ⬇️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 30.35% <0.00%> (-21.43%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 73.77% <0.00%> (-4.92%) ⬇️
...Client/Reliability/Common/SqlRetryLogicProvider.cs 89.13% <0.00%> (-2.18%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.63% <0.00%> (-0.88%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.71% <0.00%> (-0.35%) ⬇️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 83.42% <0.00%> (-0.33%) ⬇️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 73.16% <0.00%> (-0.33%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavoudEshtehari DavoudEshtehari added the Area\Tests Issues that are targeted to tests or test projects label Nov 18, 2022
@JRahnama JRahnama marked this pull request as draft November 18, 2022 19:13
@JRahnama
Copy link
Contributor Author

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JRahnama JRahnama marked this pull request as ready for review November 18, 2022 21:32
@JRahnama JRahnama merged commit 03f3053 into dotnet:main Nov 21, 2022
@JRahnama JRahnama deleted the fix-akvtestissues branch September 8, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants