TDS8 Add Server Certificate Support #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the SNIAuthProviderInfo
Codecov ReportBase: 69.25% // Head: 69.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
==========================================
- Coverage 69.25% 69.22% -0.03%
==========================================
Files 292 292
Lines 61604 61727 +123
==========================================
+ Hits 42662 42733 +71
- Misses 18942 18994 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ErikEJ
reviewed
Nov 1, 2022
ErikEJ
reviewed
Nov 1, 2022
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs
Outdated
Show resolved
Hide resolved
ErikEJ
reviewed
Nov 1, 2022
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionString.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
added
the
🆕 Public API
David-Engel
reviewed
Nov 2, 2022
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <[email protected]>
|
/azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
David-Engel
approved these changes
Nov 9, 2022
David-Engel
reviewed
Nov 9, 2022
Co-authored-by: David Engel <[email protected]>
src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.Designer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.Designer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.Designer.cs
Outdated
Show resolved
Hide resolved
…om/lcheunglci/SqlClient into TDS8-Add-ServerCertificate-Support
|
the failure seems not relevant .Connection Open() without retries took longer than expected (2 seconds) on Mac machine. |
|
The mac failures seem to intermittently occur on the pipeline in all the PRs recently, so I just have to re-run it until it succeeds. |
JRahnama
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the parameter
Server Certificateto the connection string. The server certificate is a local path to the SSL Certificate that has been download from the server. This certificate will be manually validated during the SSL Handshake. When HostNameInCertificate is specified with ServerCertificate, HNIC will take precedence. I added very basic functional test to check for the connection string parameter. Additional manual tests will be added in a later PR.