Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DateOnly and TimeOnly (SqlParameter value and GetFieldValue(Async) ) #1813

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Oct 24, 2022

fixes #1009

src/NuGet.config Outdated Show resolved Hide resolved
@JRahnama
Copy link
Contributor

@Wraith2 I have taken the old CI out and the new one will run as CI-SqlClient. Can you push some changes to validate it?

@JRahnama
Copy link
Contributor

@Wraith2 I have taken the old CI out and the new one will run as CI-SqlClient. Can you push some changes to validate it?

Sorry. I wrote in a wrong PR, but the content will apply to this PR as well. @ErikEJ can you push some changes to trigger the pipelines?

@JRahnama JRahnama added the 💡 Enhancement Issues that are feature requests for the drivers we maintain. label Oct 24, 2022
@JRahnama JRahnama added this to the 5.1.0-preview2 milestone Oct 24, 2022
@JRahnama JRahnama added Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. and removed 💡 Enhancement Issues that are feature requests for the drivers we maintain. labels Oct 24, 2022
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 25, 2022

@JRahnama CI looks good to me, a single unrelated test failing as far as I can tell.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 71.38% // Head: 71.36% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (a515e66) compared to base (20d4c19).
Patch coverage: 90.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
- Coverage   71.38%   71.36%   -0.03%     
==========================================
  Files         290      290              
  Lines       61236    61301      +65     
==========================================
+ Hits        43712    43746      +34     
- Misses      17524    17555      +31     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.91% <90.47%> (-0.10%) ⬇️
netfx 69.32% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qlClient/src/Microsoft/Data/SqlClient/SqlBuffer.cs 80.45% <77.77%> (+0.33%) ⬆️
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs 72.56% <100.00%> (-0.23%) ⬇️
...SqlClient/src/Microsoft/Data/SqlClient/SqlEnums.cs 77.77% <100.00%> (+0.39%) ⬆️
...lient/src/Microsoft/Data/SqlClient/SqlParameter.cs 75.50% <100.00%> (-0.01%) ⬇️
.../src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs 87.89% <0.00%> (-4.49%) ⬇️
.../Data/SqlClient/SNI/SslOverTdsStream.NetCoreApp.cs 47.50% <0.00%> (-4.17%) ⬇️
...osoft/Data/SqlClient/TdsParserStateObjectNative.cs 86.77% <0.00%> (-0.93%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.63% <0.00%> (-0.59%) ⬇️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 83.42% <0.00%> (-0.35%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JRahnama
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JRahnama
Copy link
Contributor

JRahnama commented Nov 2, 2022

LGTM. Only the extra package source needs to be removed.

@JRahnama JRahnama merged commit 1c03b1d into dotnet:main Nov 3, 2022
@JRahnama
Copy link
Contributor

JRahnama commented Nov 3, 2022

🎉 it is merged.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 3, 2022

@JRahnama Thanks for all the ground work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 6 | Support the new BCL DateOnly and TimeOnly structs
5 participants