-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DateOnly and TimeOnly (SqlParameter value and GetFieldValue(Async) ) #1813
Conversation
…GetFieldValue(Async)
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DateTimeTest/DateTimeTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DateTimeTest/DateTimeTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DateTimeTest/DateTimeTest.cs
Show resolved
Hide resolved
@Wraith2 I have taken the old CI out and the new one will run as CI-SqlClient. Can you push some changes to validate it? |
@JRahnama CI looks good to me, a single unrelated test failing as far as I can tell. |
Codecov ReportBase: 71.38% // Head: 71.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 71.38% 71.36% -0.03%
==========================================
Files 290 290
Lines 61236 61301 +65
==========================================
+ Hits 43712 43746 +34
- Misses 17524 17555 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
LGTM. Only the extra package source needs to be removed. |
🎉 it is merged. |
@JRahnama Thanks for all the ground work |
fixes #1009