Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing HostNameInCertificate changes in native SNI #1680

Conversation

lcheunglci
Copy link
Contributor

With some of the latest changes from SNI, the struct AuthProviderInfo includes a new field, i.e. serverCertFileName, so this change is to make sure it is compatible.

@lcheunglci lcheunglci changed the title Add ServerCertFileName in AuthProviderInfo to support TDS8 changes in SNI Addressing HINC changes in native SNI Jul 25, 2022
@lcheunglci lcheunglci changed the title Addressing HINC changes in native SNI Addressing HostNameInCertificate changes in native SNI Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1680 (867cec3) into main (cabe713) will increase coverage by 8.63%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
+ Coverage   62.29%   70.93%   +8.63%     
==========================================
  Files         293      293              
  Lines       61382    61383       +1     
==========================================
+ Hits        38237    43540    +5303     
+ Misses      23145    17843    -5302     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.43% <ø> (+9.12%) ⬆️
netfx 68.70% <100.00%> (+7.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/src/Interop/SNINativeMethodWrapper.Windows.cs 98.83% <ø> (ø)
...c/Microsoft/Data/Interop/SNINativeMethodWrapper.cs 82.10% <ø> (+17.25%) ⬆️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.65% <100.00%> (+6.76%) ⬆️
...c/Microsoft/Data/SqlClient/TdsParserSessionPool.cs 81.25% <0.00%> (-5.00%) ⬇️
...nt/src/Microsoft/Data/ProviderBase/TimeoutTimer.cs 71.42% <0.00%> (-3.58%) ⬇️
...c/Microsoft/Data/SqlClient/Server/ValueUtilsSmi.cs 64.16% <0.00%> (+0.17%) ⬆️
...Microsoft/Data/SqlClient/TdsParserHelperClasses.cs 60.79% <0.00%> (+0.33%) ⬆️
...icrosoft/Data/ProviderBase/DbConnectionInternal.cs 81.44% <0.00%> (+0.51%) ⬆️
...SqlClient/src/Microsoft/Data/SqlClient/TdsEnums.cs 92.07% <0.00%> (+0.60%) ⬆️
...Microsoft/Data/SqlClient/SqlParameterCollection.cs 98.70% <0.00%> (+0.64%) ⬆️
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lcheunglci lcheunglci marked this pull request as ready for review July 26, 2022 17:03
@DavoudEshtehari DavoudEshtehari added this to the 5.0.0 milestone Jul 26, 2022
@DavoudEshtehari DavoudEshtehari added the Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder. label Jul 26, 2022
@DavoudEshtehari
Copy link
Contributor

DavoudEshtehari commented Jul 29, 2022

FYI, after releasing the native SNI, the pipeline should be triggered with the new SNI package for this change before having merged it.

@DavoudEshtehari DavoudEshtehari added Area\Native SNI Issues that are targeted to the Native SNI codebase. and removed Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder. labels Aug 4, 2022
@DavoudEshtehari DavoudEshtehari merged commit 73875c9 into dotnet:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Native SNI Issues that are targeted to the Native SNI codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants