-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement | Dispose RandomNumberGenerator object #1478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Could you take care of the AkvStoreProviderVerifyFunctionWithInvalidSignature too?
Thanks for checking the code. I did not change the tests because dispose in the tests did not have a specific function. |
I just reran the failed pipelines, LGTM. that was nice catch @EngRajabi, well done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s great @EngRajabi
@DavoudEshtehari @Kaur-Parminder please check. thanks |
I believe you've updated the tests. I'd appreciate it if you could include the requested improvement in this PR for the sake of uniformity. |
Hello |
If you can add one more dispose in AkvStoreProviderVerifyFunctionWithInvalidSignature, we can get this merged. |
This part is inside the test. Is it that important? |
@johnnypham done! please merge |
Improvement | dispose RandomNumberGenerator object after generate randome bytes
fixes #1494