Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent subtype element in project files #1452

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented Jan 5, 2022

An empty [DesignerCategory()] causes to generate SubType element for the file in some cases. Replacing it with [DesignerCategory("")] prevents this behaviour.

/ cc @Kaur-Parminder

@Wraith2
Copy link
Contributor Author

Wraith2 commented Jan 5, 2022

@DavoudEshtehari any chance of a quick merge on this? single line change and the CI is green.

@DavoudEshtehari DavoudEshtehari merged commit 41b57bb into dotnet:main Jan 5, 2022
@DavoudEshtehari DavoudEshtehari added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Jan 5, 2022
@DavoudEshtehari DavoudEshtehari added this to the 5.0.0-preview1 milestone Jan 5, 2022
@Wraith2
Copy link
Contributor Author

Wraith2 commented Jan 5, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants